ARROW-3589: [Gandiva] Make gandiva JNI wrappers optional #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Review +1. I prefer individual settings for each project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced
ARROW_GANDIVA_JAVAflag that allows switching off building the JNI gandiva bindings.Alternatively we could also have a global
ARROW_JNIflag as suggested in https://issues.apache.org/jira/browse/ARROW-3589 which switches off all JNI wrappers (we also have JNI wrappers in plasma, which are off by default and switched on withARROW_PLASMA_JAVA_CLIENT). It might make sense to configure them individually but let me know if you have a strong preference to one or the other.