ARROW-3038: [Go] implement String array #2871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @stuartcarnie |
Codecov Report
@@ Coverage Diff @@
## master #2871 +/- ##
==========================================
- Coverage 87.55% 87.35% -0.21%
==========================================
Files 411 415 +4
Lines 63818 64461 +643
==========================================
+ Hits 55874 56308 +434
- Misses 7870 8073 +203
- Partials 74 80 +6
Continue to review full report at Codecov.
|
wesm
reviewed
Oct 31, 2018
| @@ -131,7 +131,7 @@ them internally in the [ifql][] execution engine and storage layers of [InfluxDB | |||
| - [x] 32 and 64 bit floats | |||
| - [x] Packed LSB booleans | |||
| - [x] Variable-length binary | |||
| - [ ] String (valid UTF-8) | |||
| - [x] String (valid UTF-8) | |||
| - [ ] Half-float (16-bit) | |||
| - [x] Null (no physical storage) | |||
There was a problem hiding this comment.
Can you move this TODO list to JIRA?
wesm
pushed a commit
that referenced
this pull request
Oct 31, 2018
needs #2871 Author: Sebastien Binet <binet@cern.ch> Closes #2872 from sbinet/issue-3626 and squashes the following commits: 72d9d9d <Sebastien Binet> ARROW-3626: implement CSV reader 9dfda70 <Sebastien Binet> ARROW-3625: add examples for Record and Table f2bf762 <Sebastien Binet> ARROW-3627: implement Record builder 8367d64 <Sebastien Binet> make sure Boolean implements array.Interface c055186 <Sebastien Binet> add Release, Reserve and Resize to array.Builder interface 4aaff04 <Sebastien Binet> test allocator interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs #2870