Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-1467: [C++] Remove defunct ChunkedAllocator code #3069

Closed
wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Dec 2, 2018

It does not seem that memory allocation on the dictionary encoding path requires something so elaborate right now

Change-Id: I167ce18389390a78b2e578d96d34222443ca0953
@codecov-io
Copy link

Codecov Report

Merging #3069 into master will increase coverage by 1.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3069      +/-   ##
==========================================
+ Coverage   87.09%   88.18%   +1.09%     
==========================================
  Files         489      431      -58     
  Lines       69254    65209    -4045     
==========================================
- Hits        60314    57504    -2810     
+ Misses       8839     7705    -1134     
+ Partials      101        0     -101
Impacted Files Coverage Δ
cpp/src/parquet/column_writer.h 70.58% <ø> (ø) ⬆️
cpp/src/parquet/util/memory.h 100% <ø> (ø) ⬆️
cpp/src/parquet/util/memory-test.cc 100% <ø> (ø) ⬆️
cpp/src/parquet/util/memory.cc 86.45% <ø> (+0.11%) ⬆️
cpp/src/parquet/encoding-test.cc 100% <100%> (ø) ⬆️
cpp/src/parquet/test-util.h 95.05% <100%> (ø) ⬆️
cpp/src/parquet/encoding-internal.h 97.51% <100%> (-0.02%) ⬇️
cpp/src/parquet/column_writer.cc 95.88% <100%> (-0.01%) ⬇️
go/arrow/array/table.go
go/arrow/math/uint64_amd64.go
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1621868...f37ed07. Read the comment docs.

@wesm
Copy link
Member Author

wesm commented Dec 3, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants