Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3931: [C++] Make possible to build regardless of LANG #3077

Closed
wants to merge 3 commits into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Dec 3, 2018

At the time of building C++ libs, CompilerInfo.cmake checks the version of compiler to be used.
How to check is string matching of output of gcc -v or like clang -v.
When LANG is not related to English, build will fail because string match fails.
The following is the case of ja_JP.UTF-8 (Japanese).

CMake Error at cmake_modules/CompilerInfo.cmake:92 (message):                                                                                                                                                                                 
  Unknown compiler.  Version info:                                                                                                                                                                                                            
                                                                                                                                                                                                                                              
  組み込み spec を使用しています。                                                                                                                                                                                                            
                                                                                                                                                                                                                                              
  COLLECT_GCC=/usr/bin/c++                                                                                                                                                                                                                    
                                                                                                                                                                                                                                              
  COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/4.8.5/lto-wrapper                                                                                                                                                                  
                                                                                                                                                                                                                                              
  ターゲット: x86_64-redhat-linux                                                                                                                                                                                                             
                                                                                                                                                                                                                                              
  configure 設定: ../configure --prefix=/usr --mandir=/usr/share/man                                                                                                                                                                          
  --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla                                                                                                                                                                 
  --enable-bootstrap --enable-shared --enable-threads=posix                                                                                                                                                                                   
  --enable-checking=release --with-system-zlib --enable-__cxa_atexit                                                                                                                                                                          
  --disable-libunwind-exceptions --enable-gnu-unique-object                                                                                                                                                                                   
  --enable-linker-build-id --with-linker-hash-style=gnu                                                                                                                                                                                       
  --enable-languages=c,c++,objc,obj-c++,java,fortran,ada,go,lto                                                                                                                                                                               
  --enable-plugin --enable-initfini-array --disable-libgcj                                                                                                                                                                                    
  --with-isl=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/isl-install                                                                                                                                                     
  --with-cloog=/builddir/build/BUILD/gcc-4.8.5-20150702/obj-x86_64-redhat-linux/cloog-install                                                                                                                                                 
  --enable-gnu-indirect-function --with-tune=generic --with-arch_32=x86-64                                                                                                                                                                    
  --build=x86_64-redhat-linux                                                                                                                                                                                                                 
                                                                                                                                                                                                                                              
  スレッドモデル: posix                                                                                                                                                                                                                       
                                                                                                                                                                                                                                              
  gcc バージョン 4.8.5 20150623 (Red Hat 4.8.5-11) (GCC) 

I fixed this issue by modifying CompilerInfo.cmake.

@wesm wesm changed the title ARROW-3931: Make possible to build regardless of LANG ARROW-3931: [C++] Make possible to build regardless of LANG Dec 4, 2018
@wesm
Copy link
Member

wesm commented Dec 4, 2018

I took a shot at fixing this. If this doesn't work I'll fire up my Windows machine to work on it

@sarutak
Copy link
Member Author

sarutak commented Dec 4, 2018

It seems to be fine. Thanks for fixing it!

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in ffc5154 Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants