New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3964: [Go] Refactor examples of csv reader #3131

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@c-bata
Copy link
Contributor

c-bata commented Dec 8, 2018

Example of godoc doesn't include input file(testdata/simple.csv). So it's hard to understand the output. This PR refactors it.

screenshot

https://godoc.org/github.com/apache/arrow/go/arrow/csv

arrow.Field{Name: "i64", Type: arrow.PrimitiveTypes.Int64},
arrow.Field{Name: "f64", Type: arrow.PrimitiveTypes.Float64},
arrow.Field{Name: "str", Type: arrow.BinaryTypes.String},
{Name: "i64", Type: arrow.PrimitiveTypes.Int64},

This comment has been minimized.

@c-bata

c-bata Dec 8, 2018

Contributor

just simplified. if you don't like this, I revert this changes.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 8, 2018

Codecov Report

Merging #3131 into master will decrease coverage by 19.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #3131       +/-   ##
==========================================
- Coverage   87.08%     68%   -19.09%     
==========================================
  Files         492      58      -434     
  Lines       69160    3766    -65394     
==========================================
- Hits        60228    2561    -57667     
+ Misses       8835    1108     -7727     
  Partials       97      97
Impacted Files Coverage Δ
python/pyarrow/ipc.pxi
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/gandiva/function_registry.h
cpp/src/arrow/util/int-util-test.cc
cpp/src/arrow/python/io.cc
python/pyarrow/hdfs.py
cpp/src/parquet/column_scanner.cc
... and 424 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b4a27...eed8e29. Read the comment docs.

@sbinet

sbinet approved these changes Dec 8, 2018

Copy link
Contributor

sbinet left a comment

LGTM

@c-bata c-bata changed the title ARROW-3964: [Go] Refactor examples of csv reader for Go ARROW-3964: [Go] Refactor examples of csv reader Dec 9, 2018

@kou

kou approved these changes Dec 10, 2018

Copy link
Member

kou left a comment

+1
I'll merge this.

@kou kou closed this in 7a5631d Dec 10, 2018

@c-bata c-bata deleted the c-bata:refactor-csv-reader-example branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment