New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-3964: [Go] Refactor examples of csv reader #3131
Conversation
arrow.Field{Name: "i64", Type: arrow.PrimitiveTypes.Int64}, | ||
arrow.Field{Name: "f64", Type: arrow.PrimitiveTypes.Float64}, | ||
arrow.Field{Name: "str", Type: arrow.BinaryTypes.String}, | ||
{Name: "i64", Type: arrow.PrimitiveTypes.Int64}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just simplified. if you don't like this, I revert this changes.
Codecov Report
@@ Coverage Diff @@
## master #3131 +/- ##
==========================================
- Coverage 87.08% 68% -19.09%
==========================================
Files 492 58 -434
Lines 69160 3766 -65394
==========================================
- Hits 60228 2561 -57667
+ Misses 8835 1108 -7727
Partials 97 97 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I'll merge this.
Example of godoc doesn't include input file(testdata/simple.csv). So it's hard to understand the output. This PR refactors it.
https://godoc.org/github.com/apache/arrow/go/arrow/csv