ARROW-3545: [C++/Python] Use "field" terminology with StructType, specify behavior with duplicate field names #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this. |
kszucs
reviewed
Dec 19, 2018
| std::shared_ptr<Field> GetChildByName(const std::string& name) const; | ||
|
|
||
| /// Returns -1 if name not found | ||
| ARROW_DEPRECATED("Use GetChildIndex") |
There was a problem hiding this comment.
Suggested change
| ARROW_DEPRECATED("Use GetChildIndex") | |
| ARROW_DEPRECATED("Use GetFieldIndex") |
There was a problem hiding this comment.
We must apply this change. This is a typo.
pitrou
reviewed
Dec 19, 2018
python/pyarrow/lib.pxd
Outdated
| cdef Field child_by_name(self, name) | ||
| cpdef Field child_by_name(self, name) | ||
| cpdef Field field(self, int i) | ||
| cpdef Field field_by_name(self, name) |
There was a problem hiding this comment.
I'm not sure it's useful to expose these to Python ("cpdef").
There was a problem hiding this comment.
I guess the status quo is using __getitem__ to access the children. I'll revert this change for now (easier to add APIs later than take them away)
… Define behavior of these functions when there are duplicate field names. Reflect changes in Python Change-Id: I535de5830299d310b7721c2655a1bf5d030f284e
Change-Id: Iaab46796ae0c563cc532ecca9c1abcae86352a30
Change-Id: Ibc950474ff9edb0553cbf53597df8172dd5f288a
Change-Id: Ie79c35bdf9cb8d8ef38d520df79f36e83e0c6bf6
cav71
pushed a commit
to cav71/arrow
that referenced
this pull request
Dec 22, 2018
…cify behavior with duplicate field names Author: Wes McKinney <wesm+git@apache.org> Closes apache#3220 from wesm/ARROW-3545 and squashes the following commits: dc212e6 <Wes McKinney> Fix more deprecated API uses 16e1984 <Wes McKinney> Remove field_by_name/field APIs from Python bindings, cdef only 3c4abed <Wes McKinney> Fix use of deprecated APIs 2eecdbf <Wes McKinney> Rename GetChildIndex, GetChildByName for better semantic consistency. Define behavior of these functions when there are duplicate field names. Reflect changes in Python
romainfrancois
pushed a commit
to romainfrancois/arrow
that referenced
this pull request
Jan 3, 2019
…cify behavior with duplicate field names Author: Wes McKinney <wesm+git@apache.org> Closes apache#3220 from wesm/ARROW-3545 and squashes the following commits: dc212e6 <Wes McKinney> Fix more deprecated API uses 16e1984 <Wes McKinney> Remove field_by_name/field APIs from Python bindings, cdef only 3c4abed <Wes McKinney> Fix use of deprecated APIs 2eecdbf <Wes McKinney> Rename GetChildIndex, GetChildByName for better semantic consistency. Define behavior of these functions when there are duplicate field names. Reflect changes in Python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.