Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4141: [Ruby] Add support for creating schema from raw Ruby objects #3293

Closed
wants to merge 2 commits into from

Conversation

kou
Copy link
Member

@kou kou commented Jan 1, 2019

The followings should be implemented by follow-up works:

  • Arrow::TimestampDataType.new(unit: ...)
  • Arrow::Time32DataType.new(unit: ...)
  • Arrow::Time64DataType.new(unit: ...)
  • Arrow::DecimalDataType.new(precision: ..., scale: ...)
  • Arrow::SparseUnionDataType.new(fields: ..., type_codes: ...)
  • Arrow::DenseUnionDataType.new(fields: ..., type_codes: ...)
  • Arrow::DictionaryDataType.new(fields: ..., type_codes: ...)

TODO:

  * Arrow::TimestampDataType.new(unit: ...)
  * Arrow::Time32DataType.new(unit: ...)
  * Arrow::Time64DataType.new(unit: ...)
  * Arrow::DecimalDataType.new(precision: ..., scale: ...)
  * Arrow::SparseUnionDataType.new(fields: ..., type_codes: ...)
  * Arrow::DenseUnionDataType.new(fields: ..., type_codes: ...)
  * Arrow::DictionaryDataType.new(fields: ..., type_codes: ...)
@kou kou changed the title [Ruby] Add support for creating schema from raw Ruby objects ARROW-4141: [Ruby] Add support for creating schema from raw Ruby objects Jan 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #3293 into master will decrease coverage by 20.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3293       +/-   ##
===========================================
- Coverage    88.5%   68.47%   -20.04%     
===========================================
  Files         539      366      -173     
  Lines       72968    48609    -24359     
===========================================
- Hits        64583    33285    -31298     
- Misses       8278    15324     +7046     
+ Partials      107        0      -107
Impacted Files Coverage Δ
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/hasher.h 0% <0%> (-100%) ⬇️
cpp/src/gandiva/to_date_holder.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/io/hdfs-internal.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/sse-util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/pretty_print.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/murmur3.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/int-util.cc 0.39% <0%> (-99.21%) ⬇️
cpp/src/arrow/ipc/json-simple.cc 0.41% <0%> (-98.76%) ⬇️
cpp/src/arrow/test-util.h 0% <0%> (-98.1%) ⬇️
... and 330 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9376d85...d251ba9. Read the comment docs.

Copy link
Contributor

@shiro615 shiro615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiro615 shiro615 closed this in c71d27f Jan 3, 2019
@kou kou deleted the ruby-schema-new branch January 3, 2019 20:49
emkornfield pushed a commit to emkornfield/arrow that referenced this pull request Jan 10, 2019
The followings should be implemented by follow-up works:

  * Arrow::TimestampDataType.new(unit: ...)
  * Arrow::Time32DataType.new(unit: ...)
  * Arrow::Time64DataType.new(unit: ...)
  * Arrow::DecimalDataType.new(precision: ..., scale: ...)
  * Arrow::SparseUnionDataType.new(fields: ..., type_codes: ...)
  * Arrow::DenseUnionDataType.new(fields: ..., type_codes: ...)
  * Arrow::DictionaryDataType.new(fields: ..., type_codes: ...)

Author: Kouhei Sutou <kou@clear-code.com>

Closes apache#3293 from kou/ruby-schema-new and squashes the following commits:

d251ba9 <Kouhei Sutou> Add .yardopts to rat exclude files
169b865 <Kouhei Sutou>  Add support for creating schema from raw Ruby objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants