Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33626: [Packaging][RPM] Don't remove metadata for non-target arch #33672

Merged
merged 1 commit into from Jan 15, 2023
Merged

GH-33626: [Packaging][RPM] Don't remove metadata for non-target arch #33672

merged 1 commit into from Jan 15, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jan 15, 2023 •
edited by github-actions bot

Which issue does this PR close?

Closes #33626

Rationale for this change

ADBC reuses dev/release/05-binary-upload.sh for its RPM packages. ADBC only provides x86_64 packages. ADBC doesn't provide aarch64 packages for now.

In this situation, ADBC release deletes Yum repository metadata for aarch64 unexpectedly. dev/release/05-binary-upload.sh should not touch Yum repository metadata for aarch64 in ADBC release.

What changes are included in this PR?

Copy Yum repository metadata for non-target architecture as-is.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
apacheGH-33626: [Packaging][RPM] Don't remove metadata for non-target…
695eca6 
… arch

ADBC reuses dev/release/05-binary-upload.sh for its RPM packages.
ADBC only provides x86_64 packages. ADBC doesn't provide aarch64
packages for now.

In this situation, ADBC release deletes Yum repository metadata for
aarch64 unexpectedly. dev/release/05-binary-upload.sh should not touch
Yum repository metadata for aarch64 in ADBC release.
@github-actions
Copy link

@kou
Copy link
Member Author

kou commented Jan 15, 2023

@github-actions crossbow submit almalinux-8-arm64

@github-actions
Copy link

Revision: 695eca6

Submitted crossbow builds: ursacomputing/crossbow @ actions-2cf528b305

Task Status
almalinux-8-arm64 Travis CI

@kou
Copy link
Member Author

kou commented Jan 15, 2023

+1

@kou kou merged commit 4bb7d94 into apache:master Jan 15, 2023
@kou kou deleted the release-binary-upload-not-target-arch branch January 15, 2023 13:07
@ursabot
Copy link

ursabot commented Jan 16, 2023

Benchmark runs are scheduled for baseline = 988be40 and contender = 4bb7d94. 4bb7d94 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.24% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.77% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.25% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4bb7d948 ec2-t3-xlarge-us-east-2
[Failed] 4bb7d948 test-mac-arm
[Finished] 4bb7d948 ursa-i9-9960x
[Finished] 4bb7d948 ursa-thinkcentre-m75q
[Finished] 988be40b ec2-t3-xlarge-us-east-2
[Failed] 988be40b test-mac-arm
[Finished] 988be40b ursa-i9-9960x
[Finished] 988be40b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 16, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@kou kou mentioned this pull request Apr 3, 2023
Closed
kou added a commit to kou/datafusion-c that referenced this pull request Apr 3, 2023
@kou
Update vendored apache/arrow to 11.0.0
7784063 
Fix datafusion-contrib#47.

It's for the next release. We need apache/arrow#33672.
@kou kou mentioned this pull request Apr 3, 2023
Merged
kou added a commit to datafusion-contrib/datafusion-c that referenced this pull request Apr 3, 2023
@kou
Update vendored apache/arrow to 11.0.0 (#48)
302bbdf 
Fix #47.

It's for the next release. We need apache/arrow#33672.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Packaging] The repository of AlmaLinux 9 aarch64 has not repodata.xml
2 participants
@kou @ursabot