Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33717: [Go] Flight SQL Server handle StreamChunk errors #33718

Merged
merged 1 commit into from Jan 17, 2023
Merged

GH-33717: [Go] Flight SQL Server handle StreamChunk errors #33718

merged 1 commit into from Jan 17, 2023
+155 −1

Conversation

mhilton
Copy link
Contributor

@mhilton mhilton commented Jan 17, 2023 •
edited by github-actions bot

Rationale for this change

Errors returned in the StreamChunk channel of the Flight SQL server's DoGet method are currently being dropped rather than returned to gRPC client. This is a fix for that problem.

What changes are included in this PR?

Fix the bug detailed above and add tesing for the fixed code path.

Are these changes tested?

Yes, the majority of the PR add appropriate test cases.

Are there any user-facing changes?

Only the fixed bug.

@mhilton
apacheGH-33717: [Go] Flight SQL Server handle StreamChunk errors
e67000a 
Fix the handling of errors returned when handling the stream of
StreamChunk objects in the DoGet implementation.

Also add tests for the success and error cases.
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #33717 has been automatically assigned in GitHub to PR creator.

zeroshade
zeroshade approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge it after all the CI pass.

Thanks much for the fix @mhilton!

@zeroshade zeroshade merged commit 85a111f into apache:master Jan 17, 2023
@ursabot
Copy link

ursabot commented Jan 18, 2023

Benchmark runs are scheduled for baseline = 98da819 and contender = 85a111f. 85a111f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.36% ⬆️0.06%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.06% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 85a111f8 ec2-t3-xlarge-us-east-2
[Failed] 85a111f8 test-mac-arm
[Finished] 85a111f8 ursa-i9-9960x
[Finished] 85a111f8 ursa-thinkcentre-m75q
[Finished] 98da8191 ec2-t3-xlarge-us-east-2
[Finished] 98da8191 test-mac-arm
[Finished] 98da8191 ursa-i9-9960x
[Finished] 98da8191 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees
No one assigned
Labels
Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Go] FlightSQL server elides errors in StreamChunks
3 participants
@mhilton @ursabot @zeroshade