Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-15137: [C++][CI] Fix ASAN error in streaming JSON reader tests #33772

Merged
merged 1 commit into from Jan 19, 2023

Conversation

benibus
Copy link
Collaborator

@benibus benibus commented Jan 18, 2023

The input streams passed to the reader weren't properly taking ownership of their test strings, despite the stream (potentially) outliving the test's scope.

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #15137 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one :) Thank you!

@pitrou pitrou changed the title GH-15137: [C++][CI] ASAN error in streaming JSON reader tests GH-15137: [C++][CI] Fix ASAN error in streaming JSON reader tests Jan 19, 2023
@pitrou pitrou merged commit a4236ab into apache:master Jan 19, 2023
@ursabot
Copy link

ursabot commented Jan 20, 2023

Benchmark runs are scheduled for baseline = a1a587b and contender = a4236ab. a4236ab is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.17% ⬆️0.03%] test-mac-arm
[Failed] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a4236abd ec2-t3-xlarge-us-east-2
[Finished] a4236abd test-mac-arm
[Failed] a4236abd ursa-i9-9960x
[Failed] a4236abd ursa-thinkcentre-m75q
[Finished] a1a587b1 ec2-t3-xlarge-us-east-2
[Finished] a1a587b1 test-mac-arm
[Failed] a1a587b1 ursa-i9-9960x
[Failed] a1a587b1 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 20, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++][CI] ASAN error in streaming JSON reader tests
3 participants