Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33830: Clarify handling of Null values in REE encoding #33831

Merged
merged 3 commits into from
Jan 23, 2023
Merged

GH-33830: Clarify handling of Null values in REE encoding #33831

merged 3 commits into from
Jan 23, 2023

Conversation

zagto
Copy link
Contributor

@zagto zagto commented Jan 22, 2023 •
edited by github-actions bot
Loading

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #33830 has been automatically assigned in GitHub to PR creator.

@zagto zagto changed the title GH-33830: Clarify handing of Null values in REE encoding GH-33830: Clarify handling of Null values in REE encoding Jan 22, 2023
@zagto zagto mentioned this pull request Jan 22, 2023
Closed
@zagto @westonpace
Update docs/source/format/Columnar.rst
51595aa 
Co-authored-by: Weston Pace <weston.pace@gmail.com>
westonpace
westonpace approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches my understanding (parent array has no buffers and thus, no null count)

@zeroshade zeroshade merged commit b9d1162 into apache:master Jan 23, 2023
@ursabot
Copy link

ursabot commented Jan 23, 2023

Benchmark runs are scheduled for baseline = 130dfcd and contender = b9d1162. b9d1162 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] b9d11627 ec2-t3-xlarge-us-east-2
[Failed] b9d11627 test-mac-arm
[Failed] b9d11627 ursa-i9-9960x
[Failed] b9d11627 ursa-thinkcentre-m75q
[Failed] 130dfcd1 ec2-t3-xlarge-us-east-2
[Failed] 130dfcd1 test-mac-arm
[Failed] 130dfcd1 ursa-i9-9960x
[Failed] 130dfcd1 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

alamb
alamb reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zagto

sjperkins pushed a commit to sjperkins/arrow that referenced this pull request Feb 10, 2023
@zagto @westonpace @sjperkins
apacheGH-33830: Clarify handling of Null values in REE encoding (apac…
a4f053d 
…he#33831)

* Closes: apache#33830

Lead-authored-by: Tobias Zagorni <tobias@zagorni.eu>
Co-authored-by: zagto <tobias@zagorni.eu>
Co-authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@jorisvandenbossche jorisvandenbossche mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb left review comments

@zeroshade zeroshade zeroshade approved these changes

@westonpace westonpace westonpace approved these changes

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
Component: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs][Format] Clarify handling of Null values in REE encoding
6 participants
@zagto @ursabot @alamb @zeroshade @westonpace @tustvold