-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-33977: [Dev] PR Workflow automation bot #34161
Conversation
|
8944685
to
fcf3305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! I have some comments but the main point is that we can skip using push
in favor of using github.event.action
and synchronize
to detect added changes. This should allow some simplification in the python logic too :)
I have reproduced the workflow logic on an environment like ours. I created a copy of arrow on an organization, created a fork and did some tests with a committer/non-committer user. The full workflow with the transitions can be seen on this PR: te-chie-la/arrow-pr-workflow-copy#17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change to the workflow, overall it looks good imo. The python portions also looks fine. I don't love the if else chain to compute the current state but I also don't have anything cleaner that doesn't require a bunch of useless boiler plate :D
Very much looking forward to this getting merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Let's try this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Benchmark runs are scheduled for baseline = 6cf5e89 and contender = 68e89ac. 68e89ac is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
As discussed on the mailing list is quite difficult to understand the current state of a PR whether it requires further review, it has gone stale or new changes have been added. This allows us to have a set of labels based on the state of the PR.
What changes are included in this PR?
New workflow to trigger archery bot on the required actions. New PR Workflow bot implementation on archery that manages the GitHub events and state.
New fixtures and tests.
Are these changes tested?
There are unit tests and has been tested on my fork. Some transition examples on this PR:
raulcd#74