Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-34171: [Go][Compute] Implement "Unique" kernel #34172

Merged
merged 7 commits into from Feb 14, 2023

Conversation

zeroshade
Copy link
Member

@zeroshade zeroshade commented Feb 13, 2023

Rationale for this change

Implementing a kernel for computing the "unique" values in an arrow array, primarily for use in solving #33466.

What changes are included in this PR?

Adds a "unique" function to the compute list and helper convenience functions.

Are these changes tested?

Yes, unit tests are included.

Are there any user-facing changes?

Just the new available functions.

@github-actions
Copy link

go/arrow/array/util.go Show resolved Hide resolved
go/arrow/compute/vector_hash_test.go Outdated Show resolved Hide resolved
@zeroshade zeroshade merged commit 90071cc into apache:master Feb 14, 2023
@zeroshade zeroshade deleted the vector-hash branch February 14, 2023 18:45
@ursabot
Copy link

ursabot commented Feb 15, 2023

Benchmark runs are scheduled for baseline = 266f166 and contender = 90071cc. 90071cc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.61% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.16% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 90071ccd ec2-t3-xlarge-us-east-2
[Failed] 90071ccd test-mac-arm
[Finished] 90071ccd ursa-i9-9960x
[Finished] 90071ccd ursa-thinkcentre-m75q
[Finished] 266f1666 ec2-t3-xlarge-us-east-2
[Failed] 266f1666 test-mac-arm
[Finished] 266f1666 ursa-i9-9960x
[Finished] 266f1666 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Feb 15, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this pull request Feb 17, 2023
### Rationale for this change

Implementing a kernel for computing the "unique" values in an arrow array, primarily for use in solving apache#33466. 

### What changes are included in this PR?
Adds a "unique" function to the compute list and helper convenience functions.

### Are these changes tested?
Yes, unit tests are included.

### Are there any user-facing changes?
Just the new available functions.

* Closes: apache#34171

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Feb 24, 2023
### Rationale for this change

Implementing a kernel for computing the "unique" values in an arrow array, primarily for use in solving apache#33466. 

### What changes are included in this PR?
Adds a "unique" function to the compute list and helper convenience functions.

### Are these changes tested?
Yes, unit tests are included.

### Are there any user-facing changes?
Just the new available functions.

* Closes: apache#34171

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Go][Compute] Add kernel for "unique" function
3 participants