Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-34411: [Python] Change array constructor to accept pyarrow array #34275

Merged

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Feb 21, 2023

Rationale for this change

Currently, pyarrow.array doesn't accept pyarrow Arrays and this PR adds a check to allow that.

@github-actions
Copy link

python/pyarrow/array.pxi Outdated Show resolved Hide resolved
python/pyarrow/tests/test_array.py Show resolved Hide resolved
@github-actions github-actions bot added the awaiting changes Awaiting changes label Mar 2, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 2, 2023
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Mar 2, 2023
@jorisvandenbossche jorisvandenbossche changed the title GH-21761: [Python] Change array constructor to accept pyarrow array GH-34411: [Python] Change array constructor to accept pyarrow array Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

@jorisvandenbossche jorisvandenbossche merged commit 2ebb3f7 into apache:main Mar 2, 2023
@AlenkaF AlenkaF deleted the gh-21761-array-accepting-array branch March 2, 2023 14:07
@ursabot
Copy link

ursabot commented Mar 2, 2023

Benchmark runs are scheduled for baseline = e8107bf and contender = 2ebb3f7. 2ebb3f7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.12% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.54% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2ebb3f70 ec2-t3-xlarge-us-east-2
[Failed] 2ebb3f70 test-mac-arm
[Finished] 2ebb3f70 ursa-i9-9960x
[Finished] 2ebb3f70 ursa-thinkcentre-m75q
[Finished] e8107bfa ec2-t3-xlarge-us-east-2
[Finished] e8107bfa test-mac-arm
[Finished] e8107bfa ursa-i9-9960x
[Failed] e8107bfa ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] accept pyarrow Array object in the array() constructor
3 participants