-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-33926: [Python] DataFrame Interchange Protocol for pyarrow.RecordBatch #34294
GH-33926: [Python] DataFrame Interchange Protocol for pyarrow.RecordBatch #34294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already looking good! Seeing the code to use RecordBatch reminds me we should add some small conveniences to RecordBatch that already exist on Table and can easily be added to RecordBatch as well
1eb8cf3
to
ef6983d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, looks good to me!
Benchmark runs are scheduled for baseline = 61c9a74 and contender = 6cf5e89. 6cf5e89 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
Add the implementation of the Dataframe Interchange Protocol for
pyarrow.RecordBatch
. The protocol is already implemented for pyarrow.Table, see #14804.Are these changes tested?
Yes, tests are added to: