ARROW-4323: [Packaging] Fix failing OSX clang conda forge builds #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kszucs my patch does not work. I have a different one now in the queue. Huge thanks for finding the root cause. I would like to merge this and then continue with the |
|
@xhochy Would You like to merge it now? The travis error is unrelated. |
xhochy
approved these changes
Jan 23, 2019
|
Crossbow build: https://travis-ci.org/kszucs/crossbow/builds/483303370 |
|
+1 The crossbow build is still failing, but because of some travis-ruby deployment error, which is unrelated. |
xhochy
pushed a commit
to xhochy/arrow
that referenced
this pull request
Feb 20, 2019
@xhochy I've managed to fix the xcode errors, now it's failing with the `mach_port_t` compile error. Does your [patch](conda-forge/arrow-cpp-feedstock@81ef94a) work? Author: Krisztián Szűcs <szucs.krisztian@gmail.com> Closes apache#3456 from kszucs/ARROW-4323 and squashes the following commits: 3248e25 <Krisztián Szűcs> no-conversion 7e46118 <Krisztián Szűcs> apply changes from the conda-forge resipe 27696bb <Krisztián Szűcs> workaround for run_conda_forge_build_setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xhochy I've managed to fix the xcode errors, now it's failing with the
mach_port_tcompile error.Does your patch work?