GH-34564: [Python][C++] Update code to compile with cython 3 #34726
Conversation
|
|
westonpace
changed the title
|
We could add a nightly build to catch Cython 3 issues? |
github-actions
bot
added
awaiting merge
Eventually, yes, I agree. At the moment Cython 3 hasn't released yet. The beta will not build due to known errors in the beta. I had to compile cython from the latest commit to get this to work. That's probably not worth maintaining so we can just wait and put the nightly build in (or update the existing builds) when Cython 3 is released. |
|
A couple of quick comments:
I think these are both warnings (so don't have to be breaking changes).
|
|
Thanks for this fix @westonpace! |
|
Benchmark runs are scheduled for baseline = e7d6c13 and contender = c8e0096. c8e0096 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…pache#34726) ### Rationale for this change Cython 3 has some breaking changes: * `&&` is no longer supported * `nogil` must appear at the end of the line In addition we had to work around a bug: cython/cython#5333 ### What changes are included in this PR? Minor changes to the cython code. ### Are these changes tested? No, and they probably should be at some point. However, Cython 3 has not yet released and so it would be impractical to update our CI to run Cython 3 until that happens. ### Are there any user-facing changes? No * Closes: apache#34564 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace I see that a second beta was released yesterday. Should that in principle be sufficient? (not requiring to compile latest cython manually) |
…pache#34726) ### Rationale for this change Cython 3 has some breaking changes: * `&&` is no longer supported * `nogil` must appear at the end of the line In addition we had to work around a bug: cython/cython#5333 ### What changes are included in this PR? Minor changes to the cython code. ### Are these changes tested? No, and they probably should be at some point. However, Cython 3 has not yet released and so it would be impractical to update our CI to run Cython 3 until that happens. ### Are there any user-facing changes? No * Closes: apache#34564 Authored-by: Weston Pace <weston.pace@gmail.com> Signed-off-by: Weston Pace <weston.pace@gmail.com>
…uild dependencies (#36743) ### Rationale for this change Although we already fixed some cython 3 build issues (#34726), some new have been introduced, which we are seeing now cython 3 is released (#36730) Adding an upper pin (<3) for the release, so we have more time (the full 14.0 release cycle) to iron out issues. * Closes: #36744 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
…uild dependencies (#36743) ### Rationale for this change Although we already fixed some cython 3 build issues (#34726), some new have been introduced, which we are seeing now cython 3 is released (#36730) Adding an upper pin (<3) for the release, so we have more time (the full 14.0 release cycle) to iron out issues. * Closes: #36744 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
…rrow build dependencies (apache#36743) ### Rationale for this change Although we already fixed some cython 3 build issues (apache#34726), some new have been introduced, which we are seeing now cython 3 is released (apache#36730) Adding an upper pin (<3) for the release, so we have more time (the full 14.0 release cycle) to iron out issues. * Closes: apache#36744 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
…rrow build dependencies (apache#36743) ### Rationale for this change Although we already fixed some cython 3 build issues (apache#34726), some new have been introduced, which we are seeing now cython 3 is released (apache#36730) Adding an upper pin (<3) for the release, so we have more time (the full 14.0 release cycle) to iron out issues. * Closes: apache#36744 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
Cython 3 has some breaking changes:
&&is no longer supportednogilmust appear at the end of the lineIn addition we had to work around a bug: cython/cython#5333
What changes are included in this PR?
Minor changes to the cython code.
Are these changes tested?
No, and they probably should be at some point. However, Cython 3 has not yet released and so it would be impractical to update our CI to run Cython 3 until that happens.
Are there any user-facing changes?
No