ARROW-4364: [C++] Fix CHECKIN warnings #3478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
reviewed
Jan 26, 2019
| @@ -73,7 +73,7 @@ std::shared_ptr<Buffer> CompressDataOneShot(Codec* codec, | |||
| ABORT_NOT_OK(codec->Compress(data.size(), data.data(), max_compressed_len, | |||
| compressed->mutable_data(), &compressed_len)); | |||
| ABORT_NOT_OK(compressed->Resize(compressed_len)); | |||
| return compressed; | |||
| return std::move(compressed); | |||
There was a problem hiding this comment.
I'm confused that this is needed. I would normally think that we should not std::move here as return-value-optimization should kick in.
There was a problem hiding this comment.
With clang++-7
../src/arrow/io/compressed-test.cc:76:10: error: prior to the resolution of a defect report against ISO C++11, local variable 'compressed' would have been copied despite being returned by name, due to its not matching the function return type ('shared_ptr<arrow::Buffer>' vs 'shared_ptr<arrow::ResizableBuffer>') [-Werror,-Wreturn-std-move-in-c++11]
return compressed;
^~~~~~~~~~
wesm
approved these changes
Jan 27, 2019
There was a problem hiding this comment.
+1. Thanks @fsaintjacques!
Seems like we should upgrade our clang bits to 7.0 soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.