Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35256: [Go] Add ToMap to Metadata #35257

Merged
merged 2 commits into from
Apr 22, 2023
Merged

GH-35256: [Go] Add ToMap to Metadata #35257

merged 2 commits into from
Apr 22, 2023

Conversation

yevgenypats
Copy link
Contributor

@yevgenypats yevgenypats commented Apr 20, 2023 •
edited by github-actions bot

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

This was referenced Apr 20, 2023
Closed
Merged
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 21, 2023
@zeroshade zeroshade changed the title GH-35156: [Go] Add ToMap to Metadata GH-35256: [Go] Add ToMap to Metadata Apr 22, 2023
@apache apache deleted a comment from github-actions bot Apr 22, 2023
@apache apache deleted a comment from github-actions bot Apr 22, 2023
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35256 has been automatically assigned in GitHub to PR creator.

@zeroshade zeroshade merged commit 8601aac into apache:main Apr 22, 2023
22 of 25 checks passed
@ursabot
Copy link

ursabot commented Apr 23, 2023

Benchmark runs are scheduled for baseline = a1403d4 and contender = 8601aac. 8601aac is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️1.53% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.54% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8601aac9 ec2-t3-xlarge-us-east-2
[Failed] 8601aac9 test-mac-arm
[Finished] 8601aac9 ursa-i9-9960x
[Finished] 8601aac9 ursa-thinkcentre-m75q
[Finished] a1403d46 ec2-t3-xlarge-us-east-2
[Failed] a1403d46 test-mac-arm
[Finished] a1403d46 ursa-i9-9960x
[Finished] a1403d46 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 23, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@yevgenypats @liujiacheng777
apacheGH-35256: [Go] Add ToMap to Metadata (apache#35257)
7990435 
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35256
* Closes: apache#35256

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matthew Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@yevgenypats @ArgusLi
apacheGH-35256: [Go] Add ToMap to Metadata (apache#35257)
c4bd19f 
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35256
* Closes: apache#35256

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matthew Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@yevgenypats @rtpsw
apacheGH-35256: [Go] Add ToMap to Metadata (apache#35257)
4482fa4 
### Rationale for this change

### What changes are included in this PR?

### Are these changes tested?

### Are there any user-facing changes?

* Closes: apache#35256
* Closes: apache#35256

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matthew Topol <zotthewizard@gmail.com>
@candiduslynx candiduslynx deleted the feat/metadata_tomap branch June 2, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade zeroshade left review comments

Assignees
No one assigned
Labels
awaiting changes Awaiting changes Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Go]: Add ToMap to Metadata
3 participants
@yevgenypats @ursabot @zeroshade