ARROW-4430: [C++] Fix untested TypedByteBuffer<T>::Append method #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkietz
changed the title
|
This has a compiler warning on Windows. The Travis failure is spurious |
wesm
changed the title
xhochy
pushed a commit
that referenced
this pull request
Feb 8, 2019
Author: Benjamin Kietzman <bengilgit@gmail.com> Closes #3528 from bkietz/ARROW-4430-test-typedbufferbuilder-append-copies and squashes the following commits: d70e71d <Benjamin Kietzman> explicitly cast from bool to TypeParam f739720 <Benjamin Kietzman> fixed format issue 2789a4d <Benjamin Kietzman> add test, fix append method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.