Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-557: [Python] Add option to explicitly opt in to HDFS tests, do not implicitly skip #353

Closed
wants to merge 1 commit into from
Closed

ARROW-557: [Python] Add option to explicitly opt in to HDFS tests, do not implicitly skip #353

wants to merge 1 commit into from

Conversation

wesm
Copy link
Member

@wesm wesm commented Feb 26, 2017

I have

$ py.test pyarrow/tests/test_hdfs.py 
================================== test session starts ==================================
platform linux2 -- Python 2.7.11, pytest-2.9.0, py-1.4.31, pluggy-0.3.1
rootdir: /home/wesm/code/arrow/python, inifile: 
collected 15 items 

pyarrow/tests/test_hdfs.py sssssssssssssss

But

$ py.test pyarrow/tests/test_hdfs.py --hdfs -v
================================== test session starts ==================================
platform linux2 -- Python 2.7.11, pytest-2.9.0, py-1.4.31, pluggy-0.3.1 -- /home/wesm/anaconda3/envs/py27/bin/python
cachedir: .cache
rootdir: /home/wesm/code/arrow/python, inifile: 
collected 15 items 

pyarrow/tests/test_hdfs.py::TestLibHdfs::test_hdfs_close PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs::test_hdfs_download_upload PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs::test_hdfs_file_context_manager PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs::test_hdfs_ls PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs::test_hdfs_mkdir PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs::test_hdfs_orphaned_file PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs::test_hdfs_read_multiple_parquet_files SKIPPED
pyarrow/tests/test_hdfs.py::TestLibHdfs::test_hdfs_read_whole_file PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs3::test_hdfs_close PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs3::test_hdfs_download_upload PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs3::test_hdfs_file_context_manager PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs3::test_hdfs_ls PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs3::test_hdfs_mkdir PASSED
pyarrow/tests/test_hdfs.py::TestLibHdfs3::test_hdfs_read_multiple_parquet_files SKIPPED
pyarrow/tests/test_hdfs.py::TestLibHdfs3::test_hdfs_read_whole_file PASSED

The py.test pyarrow --only-hdfs option will run only the HDFS tests.

@wesm
Add conftest.py file, hdfs group to opt in to HDFS tests with --hdfs
52e03db 
Change-Id: I00746b60939c138eb6b3ff1da2c8bf9b095fcfb1
xhochy
xhochy approved these changes Feb 27, 2017
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@asfgit asfgit closed this in dc103fe Feb 27, 2017
@wesm wesm deleted the ARROW-557 branch February 27, 2017 13:52
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 2, 2018
@wesm
PARQUET-1007: Update parquet.thrift
58689a3 
Author: Deepak Majeti <deepak.majeti@hpe.com>

Closes apache#353 from majetideepak/PARQUET-1007 and squashes the following commits:

5bb1d57 [Deepak Majeti] use NA instead of NULL, use parquet.format
155d930 [Deepak Majeti] PARQUET-1007: Update parquet.thrift
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 4, 2018
@xhochy
PARQUET-1007: Update parquet.thrift
e87fbb7 
Author: Deepak Majeti <deepak.majeti@hpe.com>

Closes apache#353 from majetideepak/PARQUET-1007 and squashes the following commits:

5bb1d57 [Deepak Majeti] use NA instead of NULL, use parquet.format
155d930 [Deepak Majeti] PARQUET-1007: Update parquet.thrift

Change-Id: Ifb2476de8a201a2f6a5d4b27df37f40e6f5ba59d
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 6, 2018
@xhochy
PARQUET-1007: Update parquet.thrift
864d059 
Author: Deepak Majeti <deepak.majeti@hpe.com>

Closes apache#353 from majetideepak/PARQUET-1007 and squashes the following commits:

5bb1d57 [Deepak Majeti] use NA instead of NULL, use parquet.format
155d930 [Deepak Majeti] PARQUET-1007: Update parquet.thrift

Change-Id: Ifb2476de8a201a2f6a5d4b27df37f40e6f5ba59d
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 7, 2018
@xhochy
PARQUET-1007: Update parquet.thrift
7cc8668 
Author: Deepak Majeti <deepak.majeti@hpe.com>

Closes apache#353 from majetideepak/PARQUET-1007 and squashes the following commits:

5bb1d57 [Deepak Majeti] use NA instead of NULL, use parquet.format
155d930 [Deepak Majeti] PARQUET-1007: Update parquet.thrift

Change-Id: Ifb2476de8a201a2f6a5d4b27df37f40e6f5ba59d
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 8, 2018
@xhochy
PARQUET-1007: Update parquet.thrift
8f7282b 
Author: Deepak Majeti <deepak.majeti@hpe.com>

Closes apache#353 from majetideepak/PARQUET-1007 and squashes the following commits:

5bb1d57 [Deepak Majeti] use NA instead of NULL, use parquet.format
155d930 [Deepak Majeti] PARQUET-1007: Update parquet.thrift

Change-Id: Ifb2476de8a201a2f6a5d4b27df37f40e6f5ba59d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wesm @xhochy