Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35335: [Python][Docs] Fix docstring of map_ #35336

Merged
merged 1 commit into from
Apr 26, 2023
Merged

GH-35335: [Python][Docs] Fix docstring of map_ #35336

merged 1 commit into from
Apr 26, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Apr 25, 2023 •
edited by jorisvandenbossche

It also accepts fields, but this isn't mentioned in the docstring

@Fokko
apacheGH-35335: [Python][Docs] Fix docstring of map_
a9bc371 
It also accepts types like `list_`, but this isn't
mentioned in the docstring
@Fokko Fokko requested a review from AlenkaF as a code owner April 25, 2023 17:15
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35335 has been automatically assigned in GitHub to PR creator.

@Fokko Fokko mentioned this pull request Apr 25, 2023
Merged
jorisvandenbossche
jorisvandenbossche approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit c38c778 into apache:main Apr 26, 2023
11 of 14 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 26, 2023
@ursabot
Copy link

ursabot commented Apr 26, 2023

Benchmark runs are scheduled for baseline = 8fbf2d7 and contender = c38c778. c38c778 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.57% ⬆️0.27%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c38c7788 ec2-t3-xlarge-us-east-2
[Failed] c38c7788 test-mac-arm
[Finished] c38c7788 ursa-i9-9960x
[Finished] c38c7788 ursa-thinkcentre-m75q
[Finished] 8fbf2d73 ec2-t3-xlarge-us-east-2
[Failed] 8fbf2d73 test-mac-arm
[Finished] 8fbf2d73 ursa-i9-9960x
[Finished] 8fbf2d73 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@Fokko @liujiacheng777
apacheGH-35335: [Python][Docs] Fix docstring of map_ (apache#35336)
7efed3e 
It also accepts fields, but this isn't mentioned in the docstring

* Closes: apache#35335

Authored-by: Fokko Driesprong <fokko@tabular.io>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@Fokko @ArgusLi
apacheGH-35335: [Python][Docs] Fix docstring of map_ (apache#35336)
5f86271 
It also accepts fields, but this isn't mentioned in the docstring

* Closes: apache#35335

Authored-by: Fokko Driesprong <fokko@tabular.io>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@Fokko @rtpsw
apacheGH-35335: [Python][Docs] Fix docstring of map_ (apache#35336)
89bb239 
It also accepts fields, but this isn't mentioned in the docstring

* Closes: apache#35335

Authored-by: Fokko Driesprong <fokko@tabular.io>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@AlenkaF AlenkaF Awaiting requested review from AlenkaF

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] Fix docstring of map_
3 participants
@Fokko @ursabot @jorisvandenbossche