Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35346: [CI][Python] Move gdb from env-file to dockerfile #35348

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented Apr 26, 2023

Rationale for this change

Similar to the issue with windows in #35057 gdb is also not available for arm64, causing benchmarks to fail.

This moves gdb into the dockerfile that actually needs it to prevent further changes. An alternative would be to use multi-arch-gdb but that is only available in -c memfault and adding on an entire new channel will only increase solve times and potentially cause problems.

@github-actions
Copy link

⚠️ GitHub issue #35346 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Apr 26, 2023
@assignUser
Copy link
Member Author

@ursabot please benchmark

@ursabot
Copy link

ursabot commented Apr 26, 2023

Benchmark runs are scheduled for baseline = 9feee48 and contender = 4d33414. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.36% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4d33414e ec2-t3-xlarge-us-east-2
[Failed] 4d33414e test-mac-arm
[Finished] 4d33414e ursa-i9-9960x
[Finished] 4d33414e ursa-thinkcentre-m75q
[Finished] 9feee48a ec2-t3-xlarge-us-east-2
[Failed] 9feee48a test-mac-arm
[Finished] 9feee48a ursa-i9-9960x
[Finished] 9feee48a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@assignUser assignUser marked this pull request as ready for review April 26, 2023 22:25
@assignUser
Copy link
Member Author

@kou could you review? The m1 benchmarks have been failing for ~ 2 weeks since #35057

@kou
Copy link
Member

kou commented Apr 26, 2023

@github-actions crossbow submit -g python

@kou
Copy link
Member

kou commented Apr 26, 2023

Oh, sorry. I didn't notice it.

@kou
Copy link
Member

kou commented Apr 26, 2023

[Failed] 9feee48a test-mac-arm

Is this out-of-scope of this pull request?

@kou
Copy link
Member

kou commented Apr 26, 2023

Ah, it's a build against the current main not this branch.

@github-actions
Copy link

Revision: 4d33414

Submitted crossbow builds: ursacomputing/crossbow @ actions-c91e76aec6

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-pandas-1.0 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-upstream_devel Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions
test-conda-python-3.9-spark-master Github Actions
test-conda-python-3.9-substrait Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure

@ursabot
Copy link

ursabot commented Apr 27, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 27, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 4409f3c into apache:main Apr 27, 2023
47 of 49 checks passed
@ursabot
Copy link

ursabot commented Apr 27, 2023

Benchmark runs are scheduled for baseline = 9feee48 and contender = 4409f3c. 4409f3c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.54% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4409f3c2 ec2-t3-xlarge-us-east-2
[Finished] 4409f3c2 test-mac-arm
[Finished] 4409f3c2 ursa-i9-9960x
[Finished] 4409f3c2 ursa-thinkcentre-m75q
[Finished] 9feee48a ec2-t3-xlarge-us-east-2
[Failed] 9feee48a test-mac-arm
[Finished] 9feee48a ursa-i9-9960x
[Finished] 9feee48a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
…ache#35348)

### Rationale for this change
Similar to the issue with windows in apache#35057 gdb is also not available for arm64, causing benchmarks to fail.

This moves gdb into the dockerfile that actually needs it to prevent further changes. An alternative would be to use multi-arch-gdb but that is only available in `-c memfault` and adding on an entire new channel will only increase solve times and potentially cause problems.

* Closes: apache#35346

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
…ache#35348)

### Rationale for this change
Similar to the issue with windows in apache#35057 gdb is also not available for arm64, causing benchmarks to fail.

This moves gdb into the dockerfile that actually needs it to prevent further changes. An alternative would be to use multi-arch-gdb but that is only available in `-c memfault` and adding on an entire new channel will only increase solve times and potentially cause problems.

* Closes: apache#35346

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
…ache#35348)

### Rationale for this change
Similar to the issue with windows in apache#35057 gdb is also not available for arm64, causing benchmarks to fail.

This moves gdb into the dockerfile that actually needs it to prevent further changes. An alternative would be to use multi-arch-gdb but that is only available in `-c memfault` and adding on an entire new channel will only increase solve times and potentially cause problems.

* Closes: apache#35346

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python][CI] Benchmark builds on osx-arm64 machine fail because gdb is not available for osx-arm64
4 participants