-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35346: [CI][Python] Move gdb from env-file to dockerfile #35348
Conversation
|
@ursabot please benchmark |
Benchmark runs are scheduled for baseline = 9feee48 and contender = 4d33414. Results will be available as each benchmark for each run completes. |
@github-actions crossbow submit -g python |
Oh, sorry. I didn't notice it. |
Is this out-of-scope of this pull request? |
Ah, it's a build against the current main not this branch. |
Revision: 4d33414 Submitted crossbow builds: ursacomputing/crossbow @ actions-c91e76aec6 |
['Python', 'R'] benchmarks have high level of regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Benchmark runs are scheduled for baseline = 9feee48 and contender = 4409f3c. 4409f3c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…ache#35348) ### Rationale for this change Similar to the issue with windows in apache#35057 gdb is also not available for arm64, causing benchmarks to fail. This moves gdb into the dockerfile that actually needs it to prevent further changes. An alternative would be to use multi-arch-gdb but that is only available in `-c memfault` and adding on an entire new channel will only increase solve times and potentially cause problems. * Closes: apache#35346 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ache#35348) ### Rationale for this change Similar to the issue with windows in apache#35057 gdb is also not available for arm64, causing benchmarks to fail. This moves gdb into the dockerfile that actually needs it to prevent further changes. An alternative would be to use multi-arch-gdb but that is only available in `-c memfault` and adding on an entire new channel will only increase solve times and potentially cause problems. * Closes: apache#35346 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ache#35348) ### Rationale for this change Similar to the issue with windows in apache#35057 gdb is also not available for arm64, causing benchmarks to fail. This moves gdb into the dockerfile that actually needs it to prevent further changes. An alternative would be to use multi-arch-gdb but that is only available in `-c memfault` and adding on an entire new channel will only increase solve times and potentially cause problems. * Closes: apache#35346 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
Similar to the issue with windows in #35057 gdb is also not available for arm64, causing benchmarks to fail.
This moves gdb into the dockerfile that actually needs it to prevent further changes. An alternative would be to use multi-arch-gdb but that is only available in
-c memfault
and adding on an entire new channel will only increase solve times and potentially cause problems.