Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-34213: [C++] Use recursive calls without a delimiter if the user is doing a recursive GetFileInfo #35440

Merged
merged 4 commits into from
Jul 25, 2023
Merged

GH-34213: [C++] Use recursive calls without a delimiter if the user is doing a recursive GetFileInfo #35440

merged 4 commits into from
Jul 25, 2023

Commits on Jul 18, 2023

  1. Changed recursive directory listing. Instead of "walk"ing the directo… 

    …ries we now rely on S3's ability to do a recursive find. This significantly reduces the number of requests made to S3.

Fix an invalid lifecycle issue.

Minor tweak to the async task scheduler.  Tasks should all be destroyed before the scheduler ends

Add missing headers

Need to use auto to avoid API inconsistency in S3

Addressing PR review comments

Add a stress test for GetFileInfoGenerator.  Fix an old bug in DeleteDirContents.  Fix a bug in GetFileInfoGenerator.

Addressing review comments

Applying suggestion from pitrou

Remove yields added for debugging

Remove accidentally added include
    @westonpace
    westonpace committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    3780a2f View commit details
    Browse the repository at this point in the history

  2. Added test for cancellation. Fixed spot where stop token was not corr… 

    …ectly hooked up. Refactored EnsureNotFileAsync into EnsureIsDirAsync and changed it to return a bool
    @westonpace
    westonpace committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    56bed6a View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Also test returned FileInfos in stress test

    @pitrou @westonpace
    pitrou authored and westonpace committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    6e75a6e View commit details
    Browse the repository at this point in the history

  2. Addressing review comments

    @westonpace
    westonpace committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7edea03 View commit details
    Browse the repository at this point in the history