Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35411: [MATLAB] Create a templated C++ Proxy Class for Numeric Arrays #35479

Merged
merged 22 commits into from
May 9, 2023
Merged

GH-35411: [MATLAB] Create a templated C++ Proxy Class for Numeric Arrays #35479

merged 22 commits into from
May 9, 2023

Commits on May 4, 2023

  1. Create a NumericArray class templated on CType to use as the proxy 

    classes for numeric arrays.

Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 4, 2023
    Configuration menu
    Copy the full SHA
    41768f0 View commit details
    Browse the repository at this point in the history

  2. Add missing header file numeric_array.h

    @sgilmore10
    sgilmore10 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    ebb44e9 View commit details
    Browse the repository at this point in the history

  3. Scoping PR to Float64 

    Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 4, 2023
    Configuration menu
    Copy the full SHA
    9b8f7b0 View commit details
    Browse the repository at this point in the history

  4. Rename Print() to ToString() and return a string array from C++. 

    Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 4, 2023
    Configuration menu
    Copy the full SHA
    cdc4672 View commit details
    Browse the repository at this point in the history

  5. Add ToMatlab() method to NumericArray Proxy Class. 

    Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 4, 2023
    Configuration menu
    Copy the full SHA
    fd84dcf View commit details
    Browse the repository at this point in the history

  6. Add basic tests for double() method for Float64Array 

    Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 4, 2023
    Configuration menu
    Copy the full SHA
    180b832 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Add test proxy class for creating arrow Arrays not backed by MATLAB 

    arrays.

Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 5, 2023
    Configuration menu
    Copy the full SHA
    42ffe1a View commit details
    Browse the repository at this point in the history

  2. Remove test class for generating arrow arrays not backed by MATLAB. 

    Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 5, 2023
    Configuration menu
    Copy the full SHA
    438ca97 View commit details
    Browse the repository at this point in the history

  3. Add file that was excluded in the previous changelist

    @sgilmore10
    sgilmore10 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    f1588b1 View commit details
    Browse the repository at this point in the history

  4. Enable creating Float64Array by copying the original Matlab array

    @sgilmore10
    sgilmore10 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    ec1a61c View commit details
    Browse the repository at this point in the history

  5. Create Array Proxy Interface for shared functionality 

    Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 5, 2023
    Configuration menu
    Copy the full SHA
    14078a8 View commit details
    Browse the repository at this point in the history

  6. 1. Add basic tests for edge case values (NaN, (+)(-)inf, realmin, rea… 

    …lmax, etc.)

2. Add DeepCopy parameterization to test points.

Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 5, 2023
    Configuration menu
    Copy the full SHA
    c4f82a6 View commit details
    Browse the repository at this point in the history

  7. Delete temporary method.

    @sgilmore10
    sgilmore10 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    5728984 View commit details
    Browse the repository at this point in the history

  8. Delete out of date comment in cmake file

    @sgilmore10
    sgilmore10 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    281933d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Fix incorrect logic deciding when to make a deep copy or not in the C++ 

    layer.

Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 8, 2023
    Configuration menu
    Copy the full SHA
    26657a4 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Fix indentation in comment 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @sgilmore10 @kou
    sgilmore10 and kou committed May 9, 2023
    Configuration menu
    Copy the full SHA
    3be33d1 View commit details
    Browse the repository at this point in the history

  2. Use auto instead of bool 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @sgilmore10 @kou
    sgilmore10 and kou committed May 9, 2023
    Configuration menu
    Copy the full SHA
    c0b6104 View commit details
    Browse the repository at this point in the history

  3. Use auto instead of size_t 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @sgilmore10 @kou
    sgilmore10 and kou committed May 9, 2023
    Configuration menu
    Copy the full SHA
    9d929a2 View commit details
    Browse the repository at this point in the history

  4. Remove extra spaces 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @sgilmore10 @kou
    sgilmore10 and kou committed May 9, 2023
    Configuration menu
    Copy the full SHA
    6c2455a View commit details
    Browse the repository at this point in the history

  5. Use auto and make_shared to create shared_ptr<arrow::Buffer> 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @sgilmore10 @kou
    sgilmore10 and kou committed May 9, 2023
    Configuration menu
    Copy the full SHA
    eb111f4 View commit details
    Browse the repository at this point in the history

  6. Fix indentation 

    Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
    @sgilmore10 @kou
    sgilmore10 and kou committed May 9, 2023
    Configuration menu
    Copy the full SHA
    f264676 View commit details
    Browse the repository at this point in the history

  7. Use ArrayData to construct Arrays. 

    Co-authored-by: Kevin Gurney <kgurney@mathworks.com>
    @sgilmore10 @kevingurney
    sgilmore10 and kevingurney committed May 9, 2023
    Configuration menu
    Copy the full SHA
    983ff90 View commit details
    Browse the repository at this point in the history