Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35503: [CI][Packaging][C++] Snappy patch fails to apply on arm64 windows wheel builds #35509

Merged
merged 6 commits into from
May 10, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented May 9, 2023

Rationale for this change

Nightly Windows wheels have been failing for the last days.

What changes are included in this PR?

Fix wrong snappy patch

Are these changes tested?

Tested on crossbow

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented May 9, 2023

⚠️ GitHub issue #35503 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented May 9, 2023

@github-actions crossbow submit wheel-windows-*

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Revision: a304295

Submitted crossbow builds: ursacomputing/crossbow @ actions-7f34a005c3

Task Status
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented May 9, 2023

@github-actions crossbow submit wheel-windows-*

@github-actions
Copy link

github-actions bot commented May 9, 2023

Revision: 828e309

Submitted crossbow builds: ursacomputing/crossbow @ actions-5b7fb9ac3c

Task Status
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented May 9, 2023

@github-actions crossbow submit wheel-windows-cp310-amd64

@github-actions
Copy link

github-actions bot commented May 9, 2023

Revision: bcd3e30

Submitted crossbow builds: ursacomputing/crossbow @ actions-19db15ad53

Task Status
wheel-windows-cp310-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented May 9, 2023

@github-actions crossbow submit wheel-windows-cp310-amd64

@github-actions
Copy link

github-actions bot commented May 9, 2023

Revision: 7066dfd

Submitted crossbow builds: ursacomputing/crossbow @ actions-7b5f53dfbc

Task Status
wheel-windows-cp310-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented May 9, 2023

@github-actions crossbow submit wheel-windows-cp310-amd64

@github-actions
Copy link

github-actions bot commented May 9, 2023

Revision: da6bc95

Submitted crossbow builds: ursacomputing/crossbow @ actions-a8809a4f9c

Task Status
wheel-windows-cp310-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented May 9, 2023

@github-actions crossbow submit wheel-windows-cp310-amd64

@github-actions
Copy link

github-actions bot commented May 9, 2023

Revision: f0b5b45

Submitted crossbow builds: ursacomputing/crossbow @ actions-586720ae29

Task Status
wheel-windows-cp310-amd64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented May 9, 2023

@github-actions crossbow submit wheel-windows-*

@github-actions
Copy link

github-actions bot commented May 9, 2023

Revision: f0b5b45

Submitted crossbow builds: ursacomputing/crossbow @ actions-0e5d9b97b6

Task Status
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@raulcd raulcd marked this pull request as ready for review May 10, 2023 08:20
@raulcd
Copy link
Member Author

raulcd commented May 10, 2023

@github-actions crossbow submit wheel-windows-*

@github-actions
Copy link

Revision: 165a257

Submitted crossbow builds: ursacomputing/crossbow @ actions-8328c33fda

Task Status
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@sjperkins
Copy link
Contributor

@raulcd Thanks for fixing this and apologies for introducing it here https://github.com/apache/arrow/pull/35430/files#r1184737729

@raulcd
Copy link
Member Author

raulcd commented May 10, 2023

@raulcd Thanks for fixing this and apologies for introducing it here https://github.com/apache/arrow/pull/35430/files#r1184737729

No worries at all, it took me more tries than expected :)

@sjperkins
Copy link
Contributor

@raulcd Thanks for fixing this and apologies for introducing it here https://github.com/apache/arrow/pull/35430/files#r1184737729

No worries at all, it took me more tries than expected :)

OK, I felt a bit bad because I'd forgotten I'd changed the patch (context switching), and ended up creating the issue based on kou's investigation.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@assignUser assignUser merged commit 3948c42 into apache:main May 10, 2023
12 of 13 checks passed
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
…rm64 windows wheel builds (apache#35509)

### Rationale for this change

Nightly Windows wheels have been failing for the last days.

### What changes are included in this PR?

Fix wrong snappy patch

### Are these changes tested?

Tested on crossbow

### Are there any user-facing changes?

No
* Closes: apache#35503

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@ursabot
Copy link

ursabot commented May 11, 2023

Benchmark runs are scheduled for baseline = df5f67d and contender = 3948c42. 3948c42 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.44% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.48% ⬆️0.54%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3948c426 ec2-t3-xlarge-us-east-2
[Finished] 3948c426 test-mac-arm
[Finished] 3948c426 ursa-i9-9960x
[Finished] 3948c426 ursa-thinkcentre-m75q
[Finished] df5f67d5 ec2-t3-xlarge-us-east-2
[Finished] df5f67d5 test-mac-arm
[Finished] df5f67d5 ursa-i9-9960x
[Finished] df5f67d5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
…rm64 windows wheel builds (apache#35509)

### Rationale for this change

Nightly Windows wheels have been failing for the last days.

### What changes are included in this PR?

Fix wrong snappy patch

### Are these changes tested?

Tested on crossbow

### Are there any user-facing changes?

No
* Closes: apache#35503

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
…rm64 windows wheel builds (apache#35509)

### Rationale for this change

Nightly Windows wheels have been failing for the last days.

### What changes are included in this PR?

Fix wrong snappy patch

### Are these changes tested?

Tested on crossbow

### Are there any user-facing changes?

No
* Closes: apache#35503

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting committer review Awaiting committer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][Packaging][C++][Windows] Snappy patch fails to apply on arm64 windows wheel builds
4 participants