New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-4479: [Plasma] Add S3 as external store for Plasma #3559
Conversation
There are other JIRA issues about adding S3 support to the project, e.g. https://issues.apache.org/jira/browse/ARROW-453. It would be a shame to miss the opportunity to set things up properly in ThirdpartyToolchain.cmake so that other parts of the C++ project can develop against the AWS SDK |
Codecov Report
@@ Coverage Diff @@
## master #3559 +/- ##
==========================================
+ Coverage 87.84% 88.59% +0.75%
==========================================
Files 739 538 -201
Lines 90879 73567 -17312
Branches 1252 0 -1252
==========================================
- Hits 79829 65175 -14654
+ Misses 10933 8392 -2541
+ Partials 117 0 -117
Continue to review full report at Codecov.
|
753608d
to
a37d180
Compare
Rebased. |
Sorry for the delay. This will have to be rebased after the pending CMake refactor goes in, stay tuned. In the interest of hardening this feature I'm going to move the issue to 0.14 so we can give thoughtful consideration to S3 support throughout the project |
@anuragkh the CMake PR has been merged, do you have time to rebase? |
ed180da
to
85fe336
Compare
Closing this PR for now. I believe we are working on S3 support as part of datasets so it might make this easier once that is done. |
https://issues.apache.org/jira/browse/ARROW-4479
This PR adds S3 as an external store, allowing objects to be evicted to S3 when Plasma runs out of memory capacity.
@pcmoritz I could use feedback on the preferred method for adding S3 as a dependency -- currently the CMake build simply uses
find_package(AWSSDK REQUIRED ...)
.