-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35749: [C++] Handle run-end encoded filters in compute kernels #35750
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bce5be4
Make GetFilterOutputSize handle REE filters
felipecrv 7e256d4
Make GetTakeIndices handle REE filters
felipecrv 7a2f2ac
ree_util: Add CompareValuesAt to ReadWriteValue
felipecrv 6cd4875
Add another convenient factory method for RunEndEncoded matcher
felipecrv 3057ef0
Make 'array_filter' handle REE filters
felipecrv 48fd629
Simplification: Remove out_offset_ variable as it's always 0
felipecrv 1473ea7
Apply suggestions from code review
felipecrv fa4e060
Fix fast path comment
felipecrv cf29d2a
Extract CheckTakeCase test utility
felipecrv 7a1f4bd
Remove cur_offset variable
felipecrv 3b88445
Revert "Simplification: Remove out_offset_ variable as it's always 0"
felipecrv 188aff0
Review all writes and make the account for out_offset
felipecrv a27b20d
Return bool from emit_segment calls
felipecrv d76883b
fix linter error
felipecrv 429fe5e
Json -> JSON, CheckTakeCase -> CheckTakeIndicesCase
felipecrv ad05570
Review all filter_may_have_nulls passed to VisitPlainxREEFilterOutput…
felipecrv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this is doing in REE utils? This is essentially representing value access in primitive arrays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing values is commonly used when run-end encoding kernels. I would happily move it out of here if you have a suggestion.