Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35754: [CI][GLib] Don't build static C++ libraries #35755

Merged
merged 1 commit into from
May 25, 2023

Conversation

kou
Copy link
Member

@kou kou commented May 25, 2023

Rationale for this change

GLib doesn't use static C++ libraries.

What changes are included in this PR?

Disable building static C++ libraries.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35754 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 25, 2023
@assignUser
Copy link
Member

@github-actions crossbow submit c-glib

@github-actions
Copy link

Revision: bbea834

Submitted crossbow builds: ursacomputing/crossbow @ actions-1cd24845ca

Task Status
test-debian-c-glib Github Actions
test-ubuntu-c-glib Github Actions

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 always nice to save ci time

@assignUser assignUser merged commit 6d2df07 into apache:main May 25, 2023
44 of 46 checks passed
@kou kou deleted the ci-glib-no-static branch May 25, 2023 05:01
@ursabot
Copy link

ursabot commented May 31, 2023

Benchmark runs are scheduled for baseline = 0cf7e39 and contender = 6d2df07. 6d2df07 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6d2df074 ec2-t3-xlarge-us-east-2
[Failed] 6d2df074 test-mac-arm
[Failed] 6d2df074 ursa-i9-9960x
[Finished] 6d2df074 ursa-thinkcentre-m75q
[Finished] 0cf7e391 ec2-t3-xlarge-us-east-2
[Failed] 0cf7e391 test-mac-arm
[Finished] 0cf7e391 ursa-i9-9960x
[Failed] 0cf7e391 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting committer review Awaiting committer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][GLib] Don't build static C++ libraries
3 participants