Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33980: [Docs][Python] Document DataFrame Interchange Protocol implementation and usage #35835

Merged
merged 9 commits into from
Jun 7, 2023
Merged

GH-33980: [Docs][Python] Document DataFrame Interchange Protocol implementation and usage #35835

merged 9 commits into from
Jun 7, 2023

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented May 31, 2023 •
edited by github-actions bot
Loading

@github-actions github-actions bot added the awaiting review Awaiting review label May 31, 2023
jorisvandenbossche
jorisvandenbossche reviewed May 31, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

docs/source/python/api/tables.rst Outdated Show resolved Hide resolved
docs/source/python/interchange_protocol.rst Outdated Show resolved Hide resolved
docs/source/python/interchange_protocol.rst Outdated Show resolved Hide resolved
docs/source/python/interchange_protocol.rst Outdated Show resolved Hide resolved
docs/source/python/interchange_protocol.rst Show resolved Hide resolved
docs/source/python/interchange_protocol.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels May 31, 2023
@AlenkaF @jorisvandenbossche
Apply suggestions from code review - Joris
c3abb8e 
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@AlenkaF AlenkaF marked this pull request as ready for review May 31, 2023 13:18
jorisvandenbossche
jorisvandenbossche approved these changes Jun 6, 2023
View reviewed changes
docs/source/python/interchange_protocol.rst Outdated Show resolved Hide resolved
docs/source/python/interchange_protocol.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 6, 2023
@raulcd raulcd mentioned this pull request Jun 6, 2023
Closed
@jorisvandenbossche jorisvandenbossche merged commit 1d75816 into apache:main Jun 7, 2023
12 checks passed
@AlenkaF AlenkaF deleted the gh-33980-df-protocol-docs branch June 7, 2023 12:37
@ursabot
Copy link

ursabot commented Jun 8, 2023

Benchmark runs are scheduled for baseline = dd26757 and contender = 1d75816. 1d75816 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.77% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 1d758162 ec2-t3-xlarge-us-east-2
[Finished] 1d758162 test-mac-arm
[Finished] 1d758162 ursa-i9-9960x
[Finished] 1d758162 ursa-thinkcentre-m75q
[Finished] dd267572 ec2-t3-xlarge-us-east-2
[Finished] dd267572 test-mac-arm
[Finished] dd267572 ursa-i9-9960x
[Finished] dd267572 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Documentation Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs][Python] Document DataFrame Interchange Protocol implementation and usage
3 participants
@AlenkaF @ursabot @jorisvandenbossche