Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35853: [Python] Fix deprecation warnings from NumPy NEP50 #35854

Merged

Conversation

danepitkin
Copy link
Contributor

@danepitkin danepitkin commented May 31, 2023

Rationale for this change

Remove warnings from the pyarrow test suite (preventing them from eventually becoming errors).

Are these changes tested?

Yes, verified no warnings are displayed.

$ python -m pytest pyarrow/tests/test_array.py -k test_cast_integers_unsafe
=================================================================== test session starts ===================================================================
platform darwin -- Python 3.11.2, pytest-7.2.2, pluggy-1.0.0
rootdir: /Users/dane/code/arrow/python, configfile: setup.cfg
plugins: hypothesis-6.70.1, cython-0.2.1, lazy-fixture-0.6.3
collected 237 items / 236 deselected / 1 selected

pyarrow/tests/test_array.py .                                                                                                                       [100%]

============================================================ 1 passed, 236 deselected in 0.24s ============================================================

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #35853 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 1, 2023
@jorisvandenbossche jorisvandenbossche merged commit e07e22c into apache:main Jun 1, 2023
13 checks passed
@ursabot
Copy link

ursabot commented Jun 1, 2023

Benchmark runs are scheduled for baseline = cbc17a9 and contender = e07e22c. e07e22c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.12% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.33% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.24% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e07e22c5 ec2-t3-xlarge-us-east-2
[Finished] e07e22c5 test-mac-arm
[Finished] e07e22c5 ursa-i9-9960x
[Finished] e07e22c5 ursa-thinkcentre-m75q
[Finished] cbc17a98 ec2-t3-xlarge-us-east-2
[Finished] cbc17a98 test-mac-arm
[Finished] cbc17a98 ursa-i9-9960x
[Finished] cbc17a98 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] NumPy NEP50 introduces deprecation of "value based" promotion of scalars
3 participants