-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35906: [Docs] Enable building the documentation without having pyarrow installed #35907
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
One question: this is excluding the full of the python docs. Longer term, should we try to only exclude the API docs? (there are currently a few files in the python/
directory that require pyarrow to be installed to run the examples in the ipython
directives, but many files also don't have this, and could in theory be built without pyarrow being installed)
Excluding files with
and I think it is connected to all 33 I can try a bit further to see where I get, if you think this would be beneficial? But I do think if one is building the docs without even binary version of pyarrow then the need for python docs is not very high. |
Yes, it certainly is less important (given that you need some python environment anyway, given that we are using sphinx to build the docs). So let's not worry about that use case here. |
This PR should be ready now @jorisvandenbossche |
Conbench analyzed the 6 benchmark runs on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
Ease the process of building the documentation for dev purposes.
What changes are included in this PR?
conf.py
is updated in a way to permit having pyarrow not installed (from source or as a binary).In case pyarrow is not available:
docs/source/python
folder will be excluded from the build of the documentation'0.0.0-local-docs-build'
I have tested the changes for cases when:
with building all of the docs and only format/developers sections.