Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35915: [Ruby] Add support for converting function options from Hash automatically #35927

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jun 6, 2023

Rationale for this change

It's convenient.

What changes are included in this PR?

This also fixes a crash bug with CallExpression.new(name, args, Arrow::MatchSubstringOptions.new). Arrow::MatchSubstringOptions.new is freed multiple times.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

…om Hash automatically

This also fixes a crash bug with `CallExpression.new(name, args,
Arrow::MatchSubstringOptions.new)`. `Arrow::MatchSubstringOptions.new`
is freed multiple times.
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

⚠️ GitHub issue #35915 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Jun 9, 2023

+1

@kou kou merged commit 766e254 into apache:main Jun 9, 2023
7 of 8 checks passed
@kou kou deleted the ruby-call-functions-options branch June 9, 2023 07:21
@ursabot
Copy link

ursabot commented Jun 10, 2023

Benchmark runs are scheduled for baseline = 3b32faa and contender = 766e254. 766e254 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.92% ⬆️0.53%] test-mac-arm
[Finished ⬇️1.31% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.15% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 766e2544 ec2-t3-xlarge-us-east-2
[Finished] 766e2544 test-mac-arm
[Finished] 766e2544 ursa-i9-9960x
[Finished] 766e2544 ursa-thinkcentre-m75q
[Finished] 3b32faaf ec2-t3-xlarge-us-east-2
[Finished] 3b32faaf test-mac-arm
[Finished] 3b32faaf ursa-i9-9960x
[Finished] 3b32faaf ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ruby] Multiple filter conditions in Arrow::Table.load
2 participants