GH-35015: [Go] Fix parquet memleak #35970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptyListsColumnReadWrite`
|
|
candiduslynx
force-pushed
the
fix/parquet/memleak
branch
6 times, most recently
from
871bd44
to
b5612d4
Compare
github-actions
bot
added
awaiting committer review
candiduslynx
commented
Jun 7, 2023
candiduslynx
commented
Jun 7, 2023
candiduslynx
commented
Jun 7, 2023
candiduslynx
commented
Jun 7, 2023
candiduslynx
force-pushed
the
fix/parquet/memleak
branch
7 times, most recently
from
380bebb
to
b0fe93b
Compare
candiduslynx
commented
Jun 7, 2023
candiduslynx
commented
Jun 7, 2023
| @@ -117,12 +111,25 @@ func (lr *leafReader) LoadBatch(nrecords int64) (err error) { | |||
| } | |||
| } | |||
| } | |||
| lr.out, err = transferColumnData(lr.recordRdr, lr.field.Type, lr.descr, lr.rctx.mem) | |||
| lr.out, err = transferColumnData(lr.recordRdr, lr.field.Type, lr.descr) | |||
There was a problem hiding this comment.
mem param was unused
candiduslynx
force-pushed
the
fix/parquet/memleak
branch
from
b0fe93b
to
a1d72fc
Compare
|
closed in favor of #35971 |
abandy
added a commit
to abandy/arrow
that referenced
this pull request
Jun 7, 2023
…dd binary, time32, and time64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some memory leaks resulted in partially skipped memory checks in pqarrow package.
This PR brings the checks back.
What changes are included in this PR?
Releases in proper places.
Are these changes tested?
Yes, the tests from #35015 are fully enabled now.
Are there any user-facing changes?
No.