Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-4520: [C++] use voidified expr to ignore DCHECK() custom messages in NDEBUG #3599

Closed
wants to merge 12 commits into from
Closed

ARROW-4520: [C++] use voidified expr to ignore DCHECK() custom messages in NDEBUG #3599

wants to merge 12 commits into from

Commits on Feb 26, 2019

  1. add ArrowLogIgnore and use for release mode DCHECK*

    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    bc43abe View commit details
    Browse the repository at this point in the history

  2. use voidified log expr for NDEBUG DCHECKs

    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    d86e114 View commit details
    Browse the repository at this point in the history

  3. don't reference undefined macros

    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    99cf328 View commit details
    Browse the repository at this point in the history

  4. use Antoine's suggestion

    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    aacbd76 View commit details
    Browse the repository at this point in the history

  5. Revert "use Antoine's suggestion" 

    This reverts commit ce91f53.
    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    ca2cdb3 View commit details
    Browse the repository at this point in the history

  6. remove side effects from DCHECK conditions

    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    87a58ee View commit details
    Browse the repository at this point in the history

  7. Revert "remove side effects from DCHECK conditions" 

    This reverts commit c35b7ad.
    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    dd76303 View commit details
    Browse the repository at this point in the history

  8. rewriting DCHECK_OK to guarantee evaluation

    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    8d7b5a1 View commit details
    Browse the repository at this point in the history

  9. rewriting DCHECK(expr.ok()) to DCHECK_OK(expr)

    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    265a36d View commit details
    Browse the repository at this point in the history

  10. Revert "rewriting DCHECK(expr.ok()) to DCHECK_OK(expr)" 

    This reverts commit 72d0930.
    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    63ee849 View commit details
    Browse the repository at this point in the history

  11. Revert "rewriting DCHECK_OK to guarantee evaluation" 

    This reverts commit 1f949fe.
    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    580498d View commit details
    Browse the repository at this point in the history

  12. use Antoine's suggestion

    @bkietz @wesm
    bkietz authored and wesm committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    e508537 View commit details
    Browse the repository at this point in the history