GH-36031: [JS]: Update dependencies #36032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: JavaScript
awaiting committer review
domoritz
commented
Jun 11, 2023
| @@ -63,7 +63,7 @@ export function joinUint8Arrays(chunks: Uint8Array[], size?: number | null): [Ui | |||
| // streaming, where we may be reading partial byte ranges out of the same underlying ArrayBuffer | |||
| const result = collapseContiguousByteRanges(chunks); | |||
| const byteLength = result.reduce((x, b) => x + b.byteLength, 0); | |||
| let source: Uint8Array, sliced: Uint8Array, buffer: Uint8Array | void; | |||
| let source: Uint8Array, sliced: Uint8Array, buffer: Uint8Array | undefined; | |||
There was a problem hiding this comment.
Without this change, TS is not happy.
github-actions
bot
added
awaiting changes
trxcllnt
approved these changes
Jun 26, 2023
|
Conbench analyzed the 6 benchmark runs on commit There were 4 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is pretty straight forward.