GH-21761: [Python] accept pyarrow scalars in array constructor #36162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlenkaF
commented
Jun 19, 2023
github-actions
bot
added
awaiting committer review
github-actions
bot
added
awaiting changes
|
I am not sure why linter is failing on this PR. I will try to rebase and see if it helps. |
github-actions
bot
added
awaiting committer review
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
AlenkaF
force-pushed
the
gh-21761_array-accepting-scalars-using-cpp
branch
from
08297d0
to
c84c3a4
Compare
|
The tests failing already have an open issue: #35728, so I think this PR is ready for review. One missing thing are the test for sets where the elements in the set get reordered when getting passed to the arrow/python/pyarrow/tests/test_convert_builtin.py Lines 2448 to 2449 in 3da9ba6 |
github-actions
bot
added
awaiting change review
|
The failing tests are all due to a known issue with |
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
jorisvandenbossche
approved these changes
Jul 5, 2023
github-actions
bot
added
awaiting merge
|
Will merge this today as the CI is green 👍 |
|
Thanks Alenka! |
|
Conbench analyzed the 6 benchmark runs on commit There were 4 benchmark results indicating a performance regression:
The full Conbench report has more details. |
This was referenced Mar 2, 2024
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Mar 8, 2024
It looks like soon after I started investigating scalar conversions for #14121 (but well before I made the PR) a major underlying hole was plugged in pyarrow via apache/arrow#36162. Most of #14121 was created to give us a way to handle scalars from pyarrow generically in libcudf. Now that pyarrow scalars can be easily tossed into arrays, we no longer really need separate scalar functions in libcudf; we can simply create an array from the scalar, put it into a table, and then call the table function. Additionally, arrow also has a function for creating an array from a scalar. This function is not new but [was previously undocumented](apache/arrow#40373). The builder code added to libcudf in #14121 can be removed and replaced with that factory. The scalar conversion is as simple as calling that arrow function and then using our preexisting `from_arrow` function on the resulting array. For now this PR is just a simplification of internals. Future PRs will remove the scalar API once we have a more standard path for the conversion of arrays via the C Data Interface. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Yunsong Wang (https://github.com/PointKernel) - David Wendt (https://github.com/davidwendt) - Bradley Dice (https://github.com/bdice) URL: #15213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Currently,
pyarrow.arraydoesn't accept list of pyarrow Scalars and this PR adds a check to allow that.