Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36218: [CI][Go] Run benchmark steps only on the main branch #36219

Merged
merged 1 commit into from Jun 22, 2023
Merged

GH-36218: [CI][Go] Run benchmark steps only on the main branch #36219

merged 1 commit into from Jun 22, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jun 21, 2023 •
edited by assignUser

Rationale for this change

Because our benchmark tool supports only the main branch.

What changes are included in this PR?

Add branch name check to the existing if:s.

Are these changes tested?

No.

Are there any user-facing changes?

No.

@kou
apacheGH-36128: [CI][Go] Run benchmark steps only on the main branch
c342808 
Because our benchmark tool supports only the main branch.
@github-actions
Copy link

⚠️ GitHub issue #36128 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 21, 2023
@westonpace
Copy link
Member

Did you mean #36218 ? I don't think #36128 is related.

@kou kou changed the title GH-36128: [CI][Go] Run benchmark steps only on the main branch GH-36218: [CI][Go] Run benchmark steps only on the main branch Jun 21, 2023
@kou
Copy link
Member Author

kou commented Jun 21, 2023

Oh, sorry. You're right. Fixed.

assignUser
assignUser approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions
Copy link

⚠️ GitHub issue #36218 has been automatically assigned in GitHub to PR creator.

@assignUser assignUser merged commit 5a58f75 into apache:main Jun 22, 2023
23 of 26 checks passed
@kou kou deleted the ci-go-benchmark-main branch June 22, 2023 00:29
kou added a commit to kou/arrow that referenced this pull request Jun 22, 2023
@kou
apacheGH-36218: [CI][Go] Run benchmark steps only on the main branch
d64aa83 
Sorry. This is a follow-up of apacheGH-36219. We need one more change for
this.
@kou kou mentioned this pull request Jun 22, 2023
Merged
kou added a commit that referenced this pull request Jun 22, 2023
@kou
GH-36218: [CI][Go] Run benchmark steps only on the main branch (#36229)
949b2a2 
### Rationale for this change

Sorry. This is a follow-up of GH-36219. We need one more change for this.

### What changes are included in this PR?

Add one more branch name check.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: #36218

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit 5a58f757.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI][Go] Run benchmark steps only on the main branch
3 participants
@kou @westonpace @assignUser