GH-36214: [C++] Specify FieldPath::Hash as template parameter where possible
#36222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benibus
changed the title
FieldPath::Hash as template parameter where possible
pitrou
approved these changes
Jun 22, 2023
github-actions
bot
added
awaiting committer review
|
Conbench analyzed the 6 benchmark runs on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Internal specializations of
std::hash<FieldPath>have caused multiple-definition errors with unity builds.What changes are included in this PR?
To avoid exposing a global specialization of
std::hash(which must be declared in thestdnamespace), this specifies theFieldPath::Hashhelper as a template parameter to hashable containers instead.Are these changes tested?
Yes (covered by existing tests)
Are there any user-facing changes?
No