Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36224: [CI] Update rest api invocations in GitHub scripts #36225

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

assignUser
Copy link
Member

The rest api calls were moved into from github. to github.rest. so the workflows are failing after the update to gh script v6.

Are these changes tested?

As these changes are in priviliged workflows testing is only possible after merge.

Closes #36224

@github-actions github-actions bot added the awaiting review Awaiting review label Jun 21, 2023
@kou kou changed the title GH-36224: Update rest api invocations in Github scripts GH-36224: [CI] Update rest api invocations in GitHub scripts Jun 21, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Let's try.

@kou kou merged commit 2329a7b into apache:main Jun 21, 2023
5 of 7 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 21, 2023
@assignUser assignUser deleted the fix-gh-script branch June 21, 2023 23:53
@raulcd
Copy link
Member

raulcd commented Jun 22, 2023

oh! of course my test on the other PR was with main! Thanks for fixing this @assignUser !

@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit 2329a7b8.

There were 5 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] GitHub script v5 introduced breaking changes
3 participants