-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36200: [CI][Docs] Avoid "No space left on device" #36230
Conversation
@github-actions crossbow submit preview-docs -g linux |
|
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit preview-docs |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit preview-docs |
This comment was marked as outdated.
This comment was marked as outdated.
@@ -72,6 +82,7 @@ jobs: | |||
# 376MB | |||
sudo rm -rf /opt/hostedtoolcache/node || : | |||
df -h | |||
df -h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's garbage.
dev/tasks/docs/github.linux.yml
Outdated
runs-on: ubuntu-latest | ||
{{ macros.github_set_env(env) }} | ||
steps: | ||
{{ macros.github_checkout_arrow(fetch_depth=fetch_depth|default(1))|indent }} | ||
{{ macros.github_install_archery()|indent }} | ||
|
||
- name: Free up disk space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add some kind of macro for this step instead of repeating it in two different files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. But the debug option approach is better.
@kou The C++ build directory takes more than 8GB in this build, which is insane (partly due to building bundled gRPC and google-cloud-cpp with static libraries). This can be trimmed down significantly by reducing the size of debug information (which isn't very useful on CI anyway). If I do:
then the size of the build directory goes down from 8GB to 5GB... We should probably do so on all gcc-based builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! I didn't notice that the big size was caused by debug option. I'll use the approach.
@@ -72,6 +82,7 @@ jobs: | |||
# 376MB | |||
sudo rm -rf /opt/hostedtoolcache/node || : | |||
df -h | |||
df -h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it's garbage.
dev/tasks/docs/github.linux.yml
Outdated
runs-on: ubuntu-latest | ||
{{ macros.github_set_env(env) }} | ||
steps: | ||
{{ macros.github_checkout_arrow(fetch_depth=fetch_depth|default(1))|indent }} | ||
{{ macros.github_install_archery()|indent }} | ||
|
||
- name: Free up disk space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. But the debug option approach is better.
Can we find a way to do that on all debug CI builds (except if MSVC is used, probably)? |
Also, it might make compilation caching more efficient (since the cached files may be smaller)... |
We can detect whether on GitHub Actions or not by But... we can't use
Hmm. We may need to use |
Or we just don't use |
@github-actions crossbow submit -g linux preview-docs |
Revision: 3c78e39 Submitted crossbow builds: ursacomputing/crossbow @ actions-1328ed330f |
The preview-docs job failure isn't "No space left on device". https://github.com/ursacomputing/crossbow/actions/runs/5368074498/jobs/9738676612#step:6:10165
|
Thanks! |
@github-actions crossbow submit preview-docs |
Revision: 60bd466 Submitted crossbow builds: ursacomputing/crossbow @ actions-8c79fd8f2e
|
@thisisnic Sorry. Could you also check this? https://github.com/apache/arrow/actions/runs/5374927859/jobs/9750784797?pr=36230#step:4:9
(You can push a fix to this branch directly.) |
@kou The failing step is due to a technicality on how we check for missing sections in the doc. Since we implemented the check in 2021, the pkgdown package now already does this check and their method is better than the one I implemented for us to do in CI. I've opened #36300 to remove it, so once that's passed CI and merged, you'll need to rebase from that. [Edit: merged now] |
Thanks! Rebased. |
The "R / AMD64 Ubuntu 20.04 R 4.2 Force-Tests true" failure is caused by #36346. So I want to merge this. If nobody objects it, I'll merge this tomorrow. |
Merged. |
Conbench analyzed the 5 benchmark runs on commit There were 7 benchmark results indicating a performance regression:
The full Conbench report has more details. |
Rationale for this change
Our build requires many disk space.
What changes are included in this PR?
Remove unused files.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
No space left on device
#36200