Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36243: [Dev] Remove PR workflow label as part of merge #36244

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jun 22, 2023

Rationale for this change

Those labels are unnecessary once they are merged. There was a conversation on Zulip about removing them in the past.

What changes are included in this PR?

Once we merge a PR we remove labels that starts with the PR workflow prefix awaiting.

Are these changes tested?

I have tested the code against an old testing PR I have here: #35323
The label was removed successfully.

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #36243 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 22, 2023
@raulcd
Copy link
Member Author

raulcd commented Jun 22, 2023

@pitrou I think you asked for this in the past. I can do a cleanup of labels once this is merged so we remove them from closed PRs.

dev/merge_arrow_pr.py Outdated Show resolved Hide resolved
dev/merge_arrow_pr.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jun 22, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 22, 2023
@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Jun 22, 2023
@@ -418,11 +418,23 @@ def merge_pr(self, number, commit_title, commit_message):
}
response = requests.put(url, headers=self.headers, json=payload)
result = response.json()
if response.status_code != 200 and 'merged' not in result:
if response.status_code == 200 and 'merged' in result:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw based on the API if the result is 200 the merge was successful and merged will always be true.
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#merge-a-pull-request
I am sure we can mark this as False if those are not successful.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 22, 2023
@raulcd raulcd added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 22, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 5c2c7ac into apache:main Jun 25, 2023
7 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 25, 2023
@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit 5c2c7acb.

There were 8 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Remove PR workflow labels once PR is merged
3 participants