Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36337: [Ruby] Relax required Apache Arrow C++ version #36338

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jun 28, 2023

Rationale for this change

Apache Arrow follows Semantic Versioning. So we can use all Apache Arrow C++ 12.*.* for Red Arrow 12.0.1. Apache Arrow C GLib 12.*.* will also work but Red Arrow 12.0.1 may depend on changes for Apache Arrow C GLib 12.0.1. So we should keep depending on the same version of Apache Arrow C GLib.

What changes are included in this PR?

Relax required Apache Arrow C++ version.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Apache Arrow follows Semantic Versioning. So we can use all Apache
Arrow C++ `12.*.*` for Red Arrow 12.0.1. Apache Arrow C GLib `12.*.*`
will also work but Red Arrow 12.0.1 may depend on changes for Apache
Arrow C GLib 12.0.1. So we should keep depending on the same version
of Apache Arrow C GLib.
@github-actions
Copy link

⚠️ GitHub issue #36337 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Jun 28, 2023

+1

@kou kou merged commit c35a35d into apache:main Jun 28, 2023
7 of 8 checks passed
@kou kou deleted the ruby-relax-cpp-version branch June 28, 2023 23:12
@kou kou removed the awaiting committer review Awaiting committer review label Jun 28, 2023
@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit c35a35d7.

There were 9 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ruby] Relax required Apache Arrow C++ version
1 participant