Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36349: [Python][CI] Avoid using 'build/etc/localtime' timezone in hypothesis tests #36391

Merged
merged 1 commit into from
Jun 30, 2023
Merged

GH-36349: [Python][CI] Avoid using 'build/etc/localtime' timezone in hypothesis tests #36391

merged 1 commit into from
Jun 30, 2023

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Jun 29, 2023 •
edited by github-actions bot
Loading

What changes are included in this PR?

Skip the test if the timezone is zoneinfo.ZoneInfo(key='build/etc/localtime'), because we don't support roundtripping such a timezone

@github-actions
Copy link

⚠️ GitHub issue #36349 has been automatically assigned in GitHub to PR creator.

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11-hypothesis

@github-actions
Copy link

Revision: a3230ba

Submitted crossbow builds: ursacomputing/crossbow @ actions-b602cce81d

Task Status
test-conda-python-3.11-hypothesis Github Actions

raulcd
raulcd approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raulcd raulcd merged commit 8fb4bf5 into apache:main Jun 30, 2023
11 of 12 checks passed
@raulcd raulcd removed the awaiting committer review Awaiting committer review label Jun 30, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 30, 2023
@jorisvandenbossche jorisvandenbossche deleted the gh-36349-hypothesis-localtime branch June 30, 2023 10:39
@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit 8fb4bf5e.

There were 2 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd approved these changes

@AlenkaF AlenkaF Awaiting requested review from AlenkaF

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python][CI] Hypothesis nightly test fails with pytz.exceptions.UnknownTimeZoneError: 'build/etc/localtime'
2 participants
@jorisvandenbossche @raulcd