Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36408: [GLib][FlightSQL] Add support for INSERT/UPDATE/DELETE #36409

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jun 30, 2023

Rationale for this change

We need the bindings of them to support INSERT/UPDATE/DELETE:

  • arrow::flight::sql::FlightSqlClient::ExecuteUpdate()
  • arrow::flight::sql::FlightSqlServerBase::DoPutCommandStatementUpdate()

What changes are included in this PR?

The bindings of them.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions
Copy link

⚠️ GitHub issue #36408 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Jul 1, 2023

+1

@kou kou merged commit 0061d79 into apache:main Jul 1, 2023
8 checks passed
@kou kou deleted the glib-flight-sql-execute-update branch July 1, 2023 22:18
@kou kou removed the awaiting committer review Awaiting committer review label Jul 1, 2023
@conbench-apache-arrow
Copy link

Conbench analyzed the 6 benchmark runs on commit 0061d79b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

westonpace pushed a commit to westonpace/arrow that referenced this pull request Jul 7, 2023
apache#36409)

### Rationale for this change

We need the bindings of them to support INSERT/UPDATE/DELETE:

* `arrow::flight::sql::FlightSqlClient::ExecuteUpdate()`
* `arrow::flight::sql::FlightSqlServerBase::DoPutCommandStatementUpdate()`

### What changes are included in this PR?

The bindings of them.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#36408

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GLib][FlightSQL] Add support for INSERT/UPDATE/DELETE
1 participant