GH-36502: [C++] Add run-end encoded array support to ReferencedByteRanges #36521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting changes
felipecrv
commented
Jul 8, 2023
bkietz
approved these changes
Jul 10, 2023
github-actions
bot
added
awaiting merge
pitrou
requested changes
Jul 10, 2023
pitrou
reviewed
Jul 11, 2023
pitrou
approved these changes
Jul 11, 2023
|
I'm going to rebase and force-push to see if these protobuf issues go away. |
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
felipecrv
force-pushed
the
ree_bytes_range
branch
from
9daa6f7
to
4d0e205
Compare
|
The protobuf issues are #36606 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit e4bf235. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
…ByteRanges (apache#36521) ### Rationale for this change Fix for apache#36502. ### What changes are included in this PR? Fix and C++ tests. ### Are these changes tested? Yes. ### Are there any user-facing changes? Addition of a new function to the `ree_util` namespace. * Closes: apache#36502 Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix for #36502.
What changes are included in this PR?
Fix and C++ tests.
Are these changes tested?
Yes.
Are there any user-facing changes?
Addition of a new function to the
ree_utilnamespace.