Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-36544: [Swift] Add/change some init methods to public access #36545

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

abandy
Copy link
Contributor

@abandy abandy commented Jul 7, 2023

Added/updated some init methods to public access for public class so these classes can be instantiated outside of the arrow package.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

⚠️ GitHub issue #36544 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label Jul 7, 2023
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit b77af9e into apache:main Jul 8, 2023
7 checks passed
@kou kou removed the awaiting review Awaiting review label Jul 8, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 8, 2023
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b77af9e.There were no benchmark performance regressions. 🎉

The full Conbench report has more details.It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

@abandy abandy deleted the GH-36544 branch April 2, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Swift] Add/change public init methods to enable access outside of Package
2 participants