GH-36482: [C++][CI] Fix sporadic test failures in AsofJoinBasicTest #36580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit verify-rc-source-macos |
|
Revision: 58a648b Submitted crossbow builds: ursacomputing/crossbow @ actions-cdacd2d9b4
|
pitrou
reviewed
Jul 10, 2023
| memo_.UpdateTime(GetTime(queue_.UnsyncFront().get(), 0)); // time changed | ||
| DCHECK_GT(queue_.UnsyncFront().batch->num_rows(), | ||
| 0); // empty batches disallowed | ||
| memo_.UpdateTime(GetTime(queue_.UnsyncFront().batch.get(), 0)); // time changed |
There was a problem hiding this comment.
Are you sure that queue_.UnsyncFront() here is the same as just above?
There was a problem hiding this comment.
Yes, because only the processing thread, which runs this code, is popping from the (front of the) queue.
github-actions
bot
added
awaiting committer review
|
In a discussion with @icexelloss, we decided to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
The key hasher is invalidated before the first invocation of
GetKey(viaGetLatestKey) after a new batch arrives. In the pre-PR code, this invalidation happens withinAdvance, which is called fromAdvanceAndMemoizeonly afterGetLatestKeyis called. The change adds numbering to record batches pushed to the processing thread to enable detecting the pushed record batch in order to then invalidate the key hasher.Are these changes tested?
Yes, by existing tests.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".