Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36629: [CI][Python] Skip dask tests due to our non-nanosecond changes in arrow->pandas conversion #36630

Merged
merged 1 commit into from
Jul 13, 2023
Merged

GH-36629: [CI][Python] Skip dask tests due to our non-nanosecond changes in arrow->pandas conversion #36630

merged 1 commit into from
Jul 13, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jul 12, 2023 •
edited by github-actions bot

Rationale for this change

Due to the changes on #33321 a dask test started failing.

What changes are included in this PR?

Skip the test in the meantime

Are these changes tested?

Yes, with crossbow

Are there any user-facing changes?

No

@raulcd
Copy link
Member Author

raulcd commented Jul 12, 2023

@github-actions crossbow submit dask

@github-actions
Copy link

⚠️ GitHub issue #36629 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 12, 2023
@raulcd raulcd requested review from jorisvandenbossche and removed request for kou and assignUser July 12, 2023 09:31
@raulcd
Copy link
Member Author

raulcd commented Jul 12, 2023

@jorisvandenbossche as you suggested I skipped the test, is there an issue we should create to follow it up?

@github-actions
Copy link

Revision: 6364629

Submitted crossbow builds: ursacomputing/crossbow @ actions-6841a6feb4

Task Status
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions

@jorisvandenbossche
Copy link
Member

@github-actions crossbow submit dask

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jul 13, 2023
@github-actions
Copy link

Revision: 6364629

Submitted crossbow builds: ursacomputing/crossbow @ actions-f91d54dfef

Task Status
test-conda-python-3.11-dask-latest Github Actions
test-conda-python-3.11-dask-upstream_devel Github Actions

@jorisvandenbossche
Copy link
Member

The upstream_devel one is now segfaulting while running the tests. But I assume that is a new / separate issue, because I see it's also happening in the nightly ones. Will try to investigate or check when this started.

@jorisvandenbossche jorisvandenbossche merged commit 3bdbd0d into apache:main Jul 13, 2023
12 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting merge Awaiting merge label Jul 13, 2023
raulcd added a commit that referenced this pull request Jul 13, 2023
@raulcd
GH-36629: [CI][Python] Skip dask tests due to our non-nanosecond chan…
e77e13a 
…ges in arrow->pandas conversion (#36630)

### Rationale for this change

Due to the changes on #33321 a dask test started failing.

### What changes are included in this PR?

Skip the test in the meantime

### Are these changes tested?

Yes, with crossbow

### Are there any user-facing changes?

No
* Closes: #36629

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jul 13, 2023
Closed
@jorisvandenbossche
Copy link
Member

is there an issue we should create to follow it up?

Let's create a reminder to remove the skip again, yes -> #36666

@j-bennet
Copy link

fyi dask/dask#10412.

chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this pull request Jul 20, 2023
@raulcd @chelseajonesr
apacheGH-36629: [CI][Python] Skip dask tests due to our non-nanosecon…
a0530a7 
…d changes in arrow->pandas conversion (apache#36630)

### Rationale for this change

Due to the changes on apache#33321 a dask test started failing.

### What changes are included in this PR?

Skip the test in the meantime

### Are these changes tested?

Yes, with crossbow

### Are there any user-facing changes?

No
* Closes: apache#36629

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 3bdbd0d.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
@raulcd @R-JunmingChen
apacheGH-36629: [CI][Python] Skip dask tests due to our non-nanosecon…
76f6b6e 
…d changes in arrow->pandas conversion (apache#36630)

### Rationale for this change

Due to the changes on apache#33321 a dask test started failing.

### What changes are included in this PR?

Skip the test in the meantime

### Are these changes tested?

Yes, with crossbow

### Are there any user-facing changes?

No
* Closes: apache#36629

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@raulcd @jorisvandenbossche @j-bennet