Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-36688: [C#] Fix dereference error #36691

Merged
merged 1 commit into from
Jul 17, 2023
Merged

GH-36688: [C#] Fix dereference error #36691

merged 1 commit into from
Jul 17, 2023

Conversation

CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented Jul 14, 2023 •
edited by github-actions bot

@github-actions
Copy link

⚠️ GitHub issue #36688 has been automatically assigned in GitHub to PR creator.

@CurtHagenlocher
Copy link
Contributor Author

@teo-tsirpanis

westonpace
westonpace approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches CArrowArrayExporter and makes sense given my understanding.

@westonpace westonpace merged commit b477501 into apache:main Jul 17, 2023
9 of 10 checks passed
@westonpace westonpace removed the awaiting review Awaiting review label Jul 17, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jul 17, 2023
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this pull request Jul 20, 2023
@CurtHagenlocher @chelseajonesr
apacheGH-36688: [C#] Fix dereference error (apache#36691)
a742aa3 
* Closes: apache#36688

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
raulcd pushed a commit that referenced this pull request Jul 25, 2023
@CurtHagenlocher @raulcd
GH-36688: [C#] Fix dereference error (#36691)
f0f27d7 
* Closes: #36688

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b477501.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this pull request Aug 20, 2023
@CurtHagenlocher @R-JunmingChen
apacheGH-36688: [C#] Fix dereference error (apache#36691)
ab1ddac 
* Closes: apache#36688

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@CurtHagenlocher CurtHagenlocher deleted the Bug36688 branch September 25, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C#] Bug in line 168 of CArrowArrayStreamExporter.cs
2 participants
@CurtHagenlocher @westonpace